Skip to content

Add disablePerformanceAntipatternChecker to scheme #694

Merged
danieleformichelli merged 3 commits into
tuist:mainfrom
Bogdan-Belogurov:main
Jun 30, 2022
Merged

Add disablePerformanceAntipatternChecker to scheme #694
danieleformichelli merged 3 commits into
tuist:mainfrom
Bogdan-Belogurov:main

Conversation

@Bogdan-Belogurov

Copy link
Copy Markdown
Contributor

Resolves #693

Short description 📝

In Xcode 14 there's a new "Thread Performance" runtime checker that is enabled by default.

Solution 📦

This PR adds disablePerformanceAntipatternChecker property to XCScheme.LaunchAction

@codecov-commenter

codecov-commenter commented Jun 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #694 (42f3367) into main (2fe19ca) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage   84.92%   84.92%           
=======================================
  Files         157      157           
  Lines        9101     9109    +8     
=======================================
+ Hits         7729     7736    +7     
- Misses       1372     1373    +1     
Impacted Files Coverage Δ
...urces/XcodeProj/Scheme/XCScheme+LaunchAction.swift 92.19% <80.00%> (-0.31%) ⬇️
Tests/XcodeProjTests/Scheme/XCSchemeTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe19ca...42f3367. Read the comment docs.

@kwridan kwridan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwridan

kwridan commented Jun 30, 2022

Copy link
Copy Markdown
Collaborator

@all-contributors add @Bogdan-Belogurov for code

@allcontributors

Copy link
Copy Markdown
Contributor

@kwridan

I've put up a pull request to add @Bogdan-Belogurov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Thread Performance Checker scheme diagnostics option

4 participants