Repository navigation
Add phototransistor schematic symbol - #452
Closed
ShayanMuhammad-CS wants to merge 1 commit into
Closed
ShayanMuhammad-CS wants to merge 1 commit into
ShayanMuhammad-CS wants to merge 1 commit into
Conversation
The phototransistor asset SVG existed (misnamed "phototransistory.svg") but was never wired up into a generated symbol. Fix the filename typo and generate the horz/vert symbol variants with descriptive collector/emitter port labels, matching the convention used by the other bipolar transistor symbols.
ShayanMuhammad-CS
requested review from
imrishabh18,
seveibar and
techmannih
as code owners
August 25, 2026 20:23
|
Someone is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
All required checks are green (Bun Test, Format Check, Type Check, Snapshot Validation). The one red status is the Vercel deploy preview, which is blocked pending maintainer authorization for first-time external contributors — not an issue with the change itself. @seveibar @mohan-bee could one of you take a look and merge when you get a chance? Happy to make any adjustments if the port labeling or orientation choice (horz/vert, matching |
Author
|
Closing this as it's been idle for a while and I'm trimming my open PRs. Thanks for the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phototransistorschematic symbol (phototransistor_horz/phototransistor_vert).assets/symbols/, but was misnamedphototransistory.svgand had never been processed into a generated symbol, so it wasn't usable via the library.phototransistor.svg, generated the symbol via the existing SVG-processing pipeline, and labeled the portscollector/emitterto match the convention used by the other bipolar transistor symbols (e.g.npn_bipolar_transistor).Test plan
bun installbun run buildbun run formatbun test— all 15 test files pass, including the new auto-generated snapshot entries forphototransistor_horz/phototransistor_vertbun run dev) shows a correct phototransistor symbol (circle body, light-arrow indicators, collector/emitter leads)