fix: encoding utf8 strings in node 20#409
Merged
tschaub merged 1 commit intotschaub:mainfrom Jan 31, 2025
Merged
Conversation
Author
|
Looks like this partially overlaps with https://github.com/tschaub/mock-fs/pull/311/files |
The writeFileUtf8 binding used by node 20 was not correctly encoding strings as utf8, and recording the file length as String.prototype.length, which returns number of utf-16 code units. If you wrote a string containing code points with a different number of utf-8 code units than utf-16 code units, then read the file back the returned string would be truncated by the difference in the number of code units.
Owner
|
Thanks for the fix, @everett1992! |
Author
|
Thanks, when will this be published? |
Owner
|
Fix is included in the v5.5.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writeFileUtf8 binding used by node 20 was not correctly encoding strings as utf8, and recording the file length as
String.prototype.length, which returns number of utf-16 code units.
If you wrote a string containing code points with a different number of utf-8 code units than utf-16 code units, then read the file back the returned string would be truncated by the difference in the number of code units.