Skip to content

fix: fix bug on utimes, futimes, add support of lutimes#366

Merged
tschaub merged 1 commit intomainfrom
dev-lutimes
Sep 23, 2022
Merged

fix: fix bug on utimes, futimes, add support of lutimes#366
tschaub merged 1 commit intomainfrom
dev-lutimes

Conversation

@3cp
Copy link
Copy Markdown
Collaborator

@3cp 3cp commented Sep 7, 2022

lutimes is available on Nodejs v14.5.0+ and v12.19.0, our CI matrix covers both versions.

closes #365

@3cp 3cp requested a review from tschaub September 7, 2022 10:09
@3cp
Copy link
Copy Markdown
Collaborator Author

3cp commented Sep 7, 2022

The existing utimes has a bug that didn't follow symlink.
Added a method getFilepath(item) to get back file path from an item. This feature is to support futimes dereferencing symlink.

@3cp
Copy link
Copy Markdown
Collaborator Author

3cp commented Sep 7, 2022

I will fix the win32 file path issue in few days.

lutimes is available on Nodejs v14.5.0+ and v12.19.0, our CI matrix
covers both versions.

closes #365
@3cp
Copy link
Copy Markdown
Collaborator Author

3cp commented Sep 8, 2022

@tschaub this one is ready for review.

Copy link
Copy Markdown
Owner

@tschaub tschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you work on this, @3cp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lutimes not supported?

2 participants