You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
npm run lint -- --fix (which is like npx eslint benchmarks lib test tasks --fix) did most of the work. The ESLint config uses rules from Prettier, so part of the fix (and rule enforcement) is done by Prettier. I use an ESLint integration for my editor, so the config in the package.json is checked when I edit, and I have the editor set up to fix on save.
A number of the changes (like adding the .js file extension on the imports) could not be auto-fixed. So those I did by hand. I take it as punishment for deciding to make that change in the linter config.
PS - I don't install anything like Prettier or ESLint globally and only use them if they are installed as a project dependency - and my editor setup only kicks in if a project has an ESLint configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates development dependencies and fixes linter issues.