fix: Replace nextTick by setImmediate.#360
Merged
tschaub merged 4 commits intotschaub:mainfrom Oct 11, 2024
regseb:promise
Merged
fix: Replace nextTick by setImmediate.#360tschaub merged 4 commits intotschaub:mainfrom regseb:promise
tschaub merged 4 commits intotschaub:mainfrom
regseb:promise
Conversation
Collaborator
|
The CI shows this fix only works for Nodejs v16+. |
Contributor
Author
|
I replaced the |
Collaborator
|
@tschaub can you review this? I am not sure about the side effect of this change. |
Contributor
Author
|
I tested mock-fs with the latest version 5.3.0 and the problem is still there.
@tschaub Can you review this PR to fix the problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
process.nextTick()bysetImmediate()to be closer to the reality of asynchronous methods. This pull request fixes #352 testcase with yauzl.