Repository navigation
fix(cua-driver): refuse unsafe GNOME 50+ helper startup - #5565
Merged
Merged
Conversation
injaneity
changed the title
injaneity
marked this pull request as ready for review
October 20, 2026 05:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: On cua 0.5.0, the bundled helper permits GNOME 50 startup despite reports of session-ending crashes with the helper active.
Fix: Refuse GNOME 50 and newer before allocating resources, stop advertising GNOME 50 support, and document disabling existing helpers. Preserve GNOME 45–49 and API 10. This contains the risk without claiming to fix the native crash.
Test: Hermetic pytest/Node lifecycle coverage runs the actual extension with mocked imports. The refusal assertion failed before the fix and passes afterward; coverage includes 50, 50.1, 50.beta, 50.rc, 51, supported 45–49 lifecycle, safe cleanup, and metadata.
Fixes #5416