Repository navigation
fix(cua-driver): pass CUA_DRIVER_RS_ENABLE_WAYLAND through to embedded hosts - #4877
Merged
Merged
Conversation
…d hosts The embedded host builds the daemon environment from an allowlist, and CUA_DRIVER_RS_ENABLE_WAYLAND was not on it. A host such as an Electron app could never turn on the native Wayland backend: the opt-in was dropped silently. Allow it, and test inheritance, an explicit host opt-in, and an explicit opt-out winning over an inherited opt-in. Ported from T3 Code's Linux patch to Cua Driver 0.34.0 (pingdotgg/t3code#16975, MIT, Copyright (c) 2026 T3 Tools Inc.); credited in THIRD_PARTY_NOTICES.md. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EmbeddedCuaDriverHostbuilds the daemon's environment from an allowlist (allowed_environment_nameincua-driver-sdk/src/embedded.rs).CUA_DRIVER_RS_ENABLE_WAYLANDwas missing from it, so on Linux an embedding host could not turn on the native Wayland backend. Neither the host's own environment nor an explicitenvironmententry got through, and nothing reported the drop.This adds the name to the allowlist. A new test covers:
0overriding an inherited1;LD_PRELOADand the approval bypass staying blocked.Credit
Ported from T3 Code's Linux patch to Cua Driver 0.34.0: pingdotgg/t3code#16975,
patches/cua-driver-linux/0.34.0.patch. T3 Code is MIT-licensed, Copyright (c) 2026 T3 Tools Inc. This PR adds a T3 Code row tolibs/cua-driver/rust/THIRD_PARTY_NOTICES.md. This is the first of a short series that upstreams that patch, so T3 Code can drop its Linux fork.Testing
cargo test -p cua-driver-sdk --lib embedded::tests: 13 passed locally, including the newwayland_backend_opt_in_reaches_embedded_driver.CI: Rust Linux unit) runs on this PR.Linear: CUA-1234 (tracking CUA-1233)
🤖 Generated with Claude Code