Skip to content

Commit 65f11ee

Browse files
committed
should improve console output
1 parent 165bc45 commit 65f11ee

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

scripts/rollup/build.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const {
1717
replaceInternalModules,
1818
getFbjsModuleAliases,
1919
replaceFbjsModuleAliases,
20+
getExternalModuleList,
2021
} = require('./modules');
2122
const {
2223
bundles,
@@ -204,9 +205,7 @@ function createBundle({babelOpts, entry, fbEntry, config, paths, name, hasteName
204205
return rollup({
205206
entry: bundleType === bundleTypes.FB ? fbEntry : entry,
206207
plugins: getPlugins(entry, babelOpts, paths, filename, bundleType),
207-
external: [
208-
'react',
209-
],
208+
external: getExternalModuleList(),
210209
}).then(({write}) => write(
211210
updateBundleConfig(config, filename, format, bundleType, hasteName)
212211
)).catch(console.error);

scripts/rollup/modules.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,26 @@ function replaceFbjsModuleAliases(bundleType) {
151151
}
152152
}
153153

154+
function getExternalModuleList() {
155+
// this is to stop Rollup spamming the console with warnings
156+
return [
157+
'react',
158+
'warning',
159+
'emptyFunction',
160+
'emptyObject',
161+
'react/lib/ReactCurrentOwner',
162+
'react/lib/checkPropTypes',
163+
'react/lib/ReactDebugCurrentFrame',
164+
'react/lib/ReactComponentTreeHook',
165+
];
166+
}
167+
154168
module.exports = {
155169
createModuleMap,
156170
getExternalModules,
157171
replaceInternalModules,
158172
getInternalModules,
159173
getFbjsModuleAliases,
160174
replaceFbjsModuleAliases,
175+
getExternalModuleList,
161176
};

0 commit comments

Comments
 (0)