Reviewing files that changed from the base of the PR and between ac93208 and ef97964.

• packages/server/src/unstable-core-do-not-import/stream/jsonl.ts (5 hunks)
• packages/tests/server/streaming.test.ts (1 hunks)

• packages/tests/server/streaming.test.ts

packages/server/src/unstable-core-do-not-import/stream/jsonl.ts (5)

420-421: LGTM! Type refinement improves type safety.

The change from ControllerChunk to ChunkData simplifies the type system by removing the custom error type, making the code more maintainable.

---

452-466: LGTM! Clean resource management.

The new clear function properly cleans up resources by replacing methods with no-ops after the stream is closed or errored. This prevents memory leaks and improves resource management.

---

486-489: LGTM! Simplified error propagation.

The cancelAll function now directly propagates the error reason without wrapping it in a custom error type. This aligns with the PR's objective of fixing stream termination errors.

---

591-594: Verify error message consistency.

The error message "Stream closed" should be consistent with other error messages in the codebase. Let's verify this.

Also applies to: 617-617

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for similar error messages in the codebase
rg -A 2 'new Error\(' packages/server/src

Length of output: 10173

---

Action: Error message consistency verified.
After reviewing the error messages across the codebase, the error message "Stream closed" in packages/server/src/unstable-core-do-not-import/stream/jsonl.ts is formatted and phrased in a manner consistent with other similar error messages (e.g., starting with a capital letter and using plain descriptive text). No discrepancy was found between this message and similar ones used elsewhere.

---

427-451: Verify error propagation in stream controller.

The error handling has been simplified by directly propagating the error reason. However, we should verify that errors are properly handled by downstream consumers.

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for error handling in downstream consumers
ast-grep --pattern 'catch (error) {
  $$$
}'

# Search for error handling in tests
rg -A 5 'controller.error' packages/server/src/unstable-core-do-not-import/stream/jsonl.test.ts

Length of output: 142

---

I'll run a new shell script to get more insights into the error propagation tests in the file. This will help verify if any tests assert that errors produced via streamController.error (and ultimately through originalController.error) are handled downstream.

---

🏁 Script executed:

#!/bin/bash
echo "=== Content of jsonl.test.ts ==="
cat packages/server/src/unstable-core-do-not-import/stream/jsonl.test.ts

echo "=== Searching for error handling patterns ==="
rg -A 10 "error(" packages/server/src/unstable-core-do-not-import/stream/jsonl.test.ts

echo "=== Searching for abort controller usage ==="
rg -n "abortController.abort" packages/server/src/unstable-core-do-not-import/stream/jsonl.test.ts

Length of output: 16678

---

Verification of Error Propagation in Stream Controller

The tests in jsonl.test.ts demonstrate that errors are properly propagated downstream. In the "encode/decode - error" test, errors thrown in both promise resolution (for deferred values) and during async iteration are caught and validated against a snapshot ([Error: Received error from server]). Additionally, producer error callbacks are invoked as expected (with snapshots verifying the error details). This confirms that the simplified error handling in the stream controller reliably passes error information to downstream consumers.