Skip to content

docs: info on httpBatchLink support for API Gateway multi-resource#5739

Closed
andrestone wants to merge 1 commit intotrpc:mainfrom
andrestone:docs/info-on-http-batch-link
Closed

docs: info on httpBatchLink support for API Gateway multi-resource#5739
andrestone wants to merge 1 commit intotrpc:mainfrom
andrestone:docs/info-on-http-batch-link

Conversation

@andrestone
Copy link
Copy Markdown

@andrestone andrestone commented May 24, 2024

Closes #5738

🎯 Changes

Info on httpBatchLink support for API Gateway + Lambda.

✅ Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@andrestone andrestone requested a review from a team as a code owner May 24, 2024 17:34
@vercel
Copy link
Copy Markdown

vercel bot commented May 24, 2024

@andrestone is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

KATT
KATT previously approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@KATT KATT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would love to add support for httpBatchLinkStreamLink too in lambda if you're keen on contributing more, happy to show you the ropes if you hop into discord and @ me. I know lambdas has support for streaming. Also working on adding support for SSE which could work for serverless too (even if it might be pricey)

@vercel
Copy link
Copy Markdown

vercel bot commented May 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 7:27pm

@KATT KATT enabled auto-merge (squash) May 24, 2024 19:23
@KATT KATT changed the base branch from main to next May 24, 2024 22:49
@KATT KATT dismissed their stale review May 24, 2024 22:49

The base branch was changed.

@KATT KATT requested a review from a team as a code owner May 24, 2024 22:49
@KATT KATT changed the base branch from next to main May 24, 2024 22:49
@KATT
Copy link
Copy Markdown
Member

KATT commented May 24, 2024

hey @andrestone, can you target next instead? we're not really working on main actively (which is v10)

@KATT
Copy link
Copy Markdown
Member

KATT commented May 24, 2024

the edit button on the site should've forked next afaict

KATT added a commit that referenced this pull request May 25, 2024
@KATT
docs: update aws-lambda.md
85ae549 
- closes #5739
- closes #5738
@KATT KATT mentioned this pull request May 25, 2024
Merged
3 tasks
@KATT KATT closed this in #5740 May 25, 2024
auto-merge was automatically disabled May 25, 2024 11:47

Pull request was closed

@andrestone
Copy link
Copy Markdown
Author

andrestone commented May 26, 2024

Thanks! Would love to add support for httpBatchLinkStreamLink too in lambda if you're keen on contributing more, happy to show you the ropes if you hop into discord and @ me. I know lambdas has support for streaming. Also working on adding support for SSE which could work for serverless too (even if it might be pricey)

Thanks for letting me know. I'll try and give it a shot when I find some room.

Cheers!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 27, 2024

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@KATT KATT KATT left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrestone @KATT