Skip to content

Conversation

@troychen728
Copy link
Owner

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #11 into SageMaker_Airflow will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           SageMaker_Airflow      #11      +/-   ##
=====================================================
- Coverage              77.12%   76.94%   -0.19%     
=====================================================
  Files                    206      206              
  Lines                  15772    15772              
=====================================================
- Hits                   12164    12135      -29     
- Misses                  3608     3637      +29
Impacted Files Coverage Δ
airflow/settings.py 73.55% <0%> (-5.79%) ⬇️
airflow/utils/sqlalchemy.py 69.56% <0%> (-4.35%) ⬇️
airflow/www_rbac/app.py 95.55% <0%> (-2.23%) ⬇️
airflow/www/app.py 97.95% <0%> (-2.05%) ⬇️
airflow/executors/__init__.py 61.53% <0%> (-1.93%) ⬇️
airflow/utils/dag_processing.py 88.6% <0%> (-0.85%) ⬇️
airflow/configuration.py 83.2% <0%> (-0.75%) ⬇️
airflow/jobs.py 82.21% <0%> (-0.53%) ⬇️
airflow/www/views.py 68.76% <0%> (-0.13%) ⬇️
airflow/models.py 88.45% <0%> (-0.09%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920ecd3...d76af99. Read the comment docs.

@troychen728 troychen728 merged commit 82f8282 into SageMaker_Airflow Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants