NuGet updates #1678
NuGet updates #1678
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates multiple NuGet package dependencies across the solution to their latest versions, including AWS SDK libraries, Azure Identity packages, Microsoft Identity libraries, and other dependencies. The update also includes code changes to accommodate breaking changes in the Humanizer package upgrade from version 2.14.1 to 3.0.1.
Key Changes:
- Upgraded Humanizer from v2.14.1 to v3.0.1 with corresponding namespace updates
- Updated Microsoft Identity libraries from v8.14.0 to v8.15.0
- Updated AWS SDK packages (Core, S3, SQS) to latest versions
- Removed unnecessary using directives and fixed resource references
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| DBADashSharedGUI/DBADashSharedGUI.csproj | Updated Markdig from 0.43.0 to 0.44.0 |
| DBADashServiceConfig/ServiceConfigTool.csproj | Updated AWS SDK, Azure Identity, Humanizer, Microsoft Identity, and System.Management.Automation packages |
| DBADashService/DBADashService.csproj | Updated AWS SDK, Azure Identity, Humanizer, Microsoft Identity, and Serilog.Settings.Configuration packages |
| DBADashGUI/Performance/Waits.cs | Updated Humanizer namespace from Humanizer.Localisation.TimeUnit to TimeUnit |
| DBADashGUI/Performance/RunningQueries.cs | Removed unused using TimeUnit = Humanizer.Localisation.TimeUnit; directive |
| DBADashGUI/Main.cs | Fixed resource references from Resources to Properties.Resources |
| DBADashGUI/DBADashGUI.csproj | Updated Humanizer from 2.14.1 to 3.0.1 |
| DBADashGUI/Checks/Summary.cs | Removed unused using Humanizer.Localisation; directive |
| DBADash/DBADash.csproj | Updated AWS SDK, Azure Identity, Humanizer.Core, Microsoft Identity, Polly.Core, and System.Management.Automation packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tsTopWaits.ToolTipText = string.Join(Environment.NewLine, | ||
| topWaits.Select(x => x.WaitType + " - " | ||
| + TimeSpan.FromSeconds(Convert.ToDouble(x.WaitTime)).Humanize(2, minUnit: Humanizer.Localisation.TimeUnit.Second) | ||
| + TimeSpan.FromSeconds(Convert.ToDouble(x.WaitTime)).Humanize(2, minUnit: TimeUnit.Second) |
There was a problem hiding this comment.
The code references TimeUnit.Second without a using directive or fully qualified namespace. Since the using directive using TimeUnit = Humanizer.Localisation.TimeUnit; was removed from RunningQueries.cs, verify that this file has the appropriate using directive or consider using the fully qualified name Humanizer.Localisation.TimeUnit.Second for consistency.
| + TimeSpan.FromSeconds(Convert.ToDouble(x.WaitTime)).Humanize(2, minUnit: TimeUnit.Second) | |
| + TimeSpan.FromSeconds(Convert.ToDouble(x.WaitTime)).Humanize(2, minUnit: Humanizer.Localisation.TimeUnit.Second) |
1 participant
No description provided.