Object Execution Tab - Context fix #1675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supply ObjectName parameter when applicable.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the logic for determining when to supply the ObjectName parameter in the Object Execution tab, ensuring it is only provided when the context type is a Query Store object type. This aligns with similar filtering already applied to the ObjectID parameter.
- Replaced the database type check for
ObjectIDwith a more preciseIsQueryStoreObjectType()method - Added a new
ObjectNameproperty that conditionally returns the object name based on context type - Updated the parameter assignment to use the new
ObjectNameproperty instead of directly accessingCurrentContext.ObjectName
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only supply ObjectName parameter when applicable.