Update Build Reference Fix #1673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to use new URL Update code to handle redirects. trimble-oss#1672
Redirect is working in workflows, but update to the new URL anyway.
DavidWiseman
force-pushed
the
1672_UpdateBuildReferenceFix
branch
from
33699af to
a1d76be
Compare
Apply suggestions from code review & additional optimizations
DavidWiseman
force-pushed
the
1672_UpdateBuildReferenceFix
branch
from
a1d76be to
c402857
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+120
to
+121
| // Defensive: shouldn't reach here; loop returns or throws above | ||
| throw new HttpRequestException($"Unexpected termination while fetching '{url}'. Redirects followed: {redirectCount}."); |
There was a problem hiding this comment.
This unreachable code should be removed. The while(true) loop at line 62 always returns or throws within the loop body, making lines 120-121 unreachable. Remove these lines to improve code clarity.
Suggested change
| // Defensive: shouldn't reach here; loop returns or throws above | |
| throw new HttpRequestException($"Unexpected termination while fetching '{url}'. Redirects followed: {redirectCount}."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use new URL
Update code to handle redirects.
#1672