Grant logon as a service rights when installing service #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service will fail to start if the user doesn't have logon as a service rights. Grant this automatically as part of the install to ensure a smoother installation experience.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the service installation process by automatically granting "Log on as a service" rights to the service account user. This prevents installation failures caused by missing permissions and improves the overall installation experience.
Key changes:
- Implements LSA (Local Security Authority) utility functions to check and grant logon as service rights
- Integrates permission checking and granting into the service installation workflow with user feedback
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DBADashServiceConfig/LsaUtility.cs | New utility class providing LSA API interop for checking and granting logon as service rights |
| DBADashServiceConfig/InstallService.cs | Updated installation flow to check for and grant logon as service rights before installing the service |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service will fail to start if the user doesn't have logon as a service rights. Grant this automatically as part of the install to ensure a smoother installation experience.