sys.database_service_objectives collection fix #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where incorrect information was returned for the master database due to DB_ID() returning a different value for the database_id than sys.databases.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the master database query was returning incorrect information due to a mismatch between DB_ID() and the database_id values in sys.database_service_objectives. The fix changes the query to join with sys.databases and filter by database name instead of ID.
Key Changes:
- Replaced direct
DB_ID()filtering with a join tosys.databasesand filtering byDB_NAME() - Added table aliases for improved readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where incorrect information was returned for the master database due to DB_ID() returning a different value for the database_id than sys.databases. #1627