Running Queries - Cursor collection #1639
Conversation
DavidWiseman
force-pushed
the
1635_RunningQueriesCursor
branch
from
a4bdc4c to
ac90390
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 29 out of 31 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- DBADashGUI/Performance/RunningQueries.Designer.cs: Language not supported
- DBADashServiceConfig/ServiceConfig.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| DELETE QT | ||
| DELETE TOP(@BatchSize) QT | ||
| FROM dbo.QueryText QT |
There was a problem hiding this comment.
The DELETE statement was changed from DELETE QT to DELETE TOP(@BatchSize) QT. This should have a corresponding OUTPUT clause like the cursor delete at line 36-38 to track deleted sql_handles, otherwise the @deleted table will only contain handles from cursor deletions. This creates an inconsistency where query text cleanup may not work correctly for all deleted running queries.
| FROM dbo.QueryText QT | |
| FROM dbo.QueryText QT | |
| OUTPUT DELETED.sql_handle INTO @deleted(sql_handle) |
There was a problem hiding this comment.
No output clause is needed here - we are using the @deleted table variable to determine what to delete from QueryText.
1 participant
#1635