Running Queries - duration calculation #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use calculated duration instead of total_elapsed_time if total_elapsed_time appears to be suspect. If the durations are within 500ms or the calculated duration is negative and total_elapsed_time is less than 30 seconds, use total_elapsed_time. trimble-oss#1491
Add total_elapsed_time column in addition to calculated duration.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines duration calculation for running queries by implementing a fallback strategy when total_elapsed_time appears unreliable. Instead of always using total_elapsed_time, the code now calculates duration based on timestamp differences and only uses total_elapsed_time when it agrees with the calculated value (within 500ms) or under specific edge cases.
- Implements conditional duration calculation logic with fallback strategy
- Adds
total_elapsed_timecolumn to query results for transparency - Updates UI to display the raw
total_elapsed_timevalue as a hidden column
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| DBADashGUI/Performance/RunningQueries.cs | Adds hidden UI column for raw total_elapsed_time value |
| DBADashDB/dbo/Views/RunningQueriesInfo.sql | Implements conditional duration calculation logic and exposes total_elapsed_time |
| DBADashDB/dbo/Stored Procedures/RunningQueries_Upd.sql | Applies same duration calculation logic to the stored procedure |
| DBADashDB/dbo/Stored Procedures/RunningQueries_Get.sql | Adds total_elapsed_time to result set |
| DBADashDB/dbo/Stored Procedures/RunningQueriesForSession_Get.sql | Adds total_elapsed_time to result set |
| DBADashDB/dbo/Stored Procedures/RunningQueriesForJob_Get.sql | Adds total_elapsed_time to result set |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use calculated duration instead of total_elapsed_time if total_elapsed_time appears to be suspect. If the durations are within 500ms or the calculated duration is negative and total_elapsed_time is less than 30 seconds, use total_elapsed_time.
Add total_elapsed_time column in addition to calculated duration.
#1491