Report designer fixes #1602
Merged
Report designer fixes #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Designer needs to be updated for ColumnMetadata. The backward compatibility layer works for deserialization, but does not support adding items to dictionaries.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Purpose: Update the custom report designer to rely on ColumnMetadata for per-column settings (visibility, links, formatting, highlighting, etc.) and add support for hiding certain identifier columns.
- Introduces use of ColumnMetadata for storing highlighting, link, format, timezone conversion, and description settings.
- Adds explicit visibility settings for InstanceID and DatabaseID columns in relevant reports.
- Refactors prior per-column dictionaries (e.g., CellHighlightingRules, LinkColumns, CellFormatString, DoNotConvertToLocalTimeZone) toward unified ColumnMetadata, though some legacy references remain.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DBADashGUI/ExtensionMethods.cs | Removes fallback that hid columns absent from saved layout. |
| DBADashGUI/CustomReports/NewDatabasesReport.cs | Marks InstanceID column as not visible via ColumnMetadata. |
| DBADashGUI/CustomReports/DatabaseFinderReport.cs | Adds hidden DatabaseID column metadata. |
| DBADashGUI/CustomReports/CustomReportView.cs | Refactors multiple per-column operations (highlighting, links, formatting, timezone, description) to use ColumnMetadata; adds helper GetColumnMetadata. |
Comments suppressed due to low confidence (1)
DBADashGUI/ExtensionMethods.cs:1
- [nitpick] Removing this else block alters LoadColumnLayout behavior so columns without saved settings remain visible instead of being hidden. If the intent is strict restoration (show only saved columns), consider retaining logic or adding a comment clarifying the new expected behavior to avoid confusion.
using DBADashGUI.CustomReports;
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designer needs to be updated for ColumnMetadata. The backward compatibility layer works for deserialization, but does not support adding items to dictionaries.