TableSize collection fix #1593
Merged
TableSize collection fix #1593
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix truncation of TableSizeDatabases parameter that can occur due to LIKE encoding causing the text length to be increased from its calculated size.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a parameter truncation issue in the TableSize collection functionality where the TableSizeDatabases parameter could be truncated due to LIKE encoding causing the text length to exceed its calculated size.
Key Changes:
- Modified SqlParameter constructor for TableSizeDatabases to explicitly specify NVarChar with maximum length (-1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| { | ||
| param = new[] { new SqlParameter("SizeThresholdMB", Source.TableSizeCollectionThresholdMB ?? TableSizeCollectionThresholdMBDefault), | ||
| new SqlParameter("TableSizeDatabases", Source.TableSizeDatabases ?? TableSizeDatabasesDefault), | ||
| new SqlParameter("TableSizeDatabases", SqlDbType.NVarChar,-1) { Value = Source.TableSizeDatabases ?? TableSizeDatabasesDefault}, |
There was a problem hiding this comment.
[nitpick] There should be a space after the comma between SqlDbType.NVarChar and -1 for consistency with coding standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix truncation of TableSizeDatabases parameter that can occur due to LIKE encoding causing the text length to be increased from its calculated size.