This repository was archived by the owner on Nov 5, 2024. It is now read-only.
GCP targets IAM identity#1472
Merged
Merged
Conversation
b7bf33c to
4f01366
Compare
FranBarrera
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCP sources spec update
BREAKING CHANGE: GCP sources parameter
spec.serviceAccountKey(deprecated in #1316) is completely removed in favor ofspec.auth.serviceAccountKeyGoogle Cloud Platform targets authentication spec update
Resolves #1463
BREAKING CHANGE:
spec.credentialsJsonis replaced withspec.auth.serviceAccountKeyThis PR introduces IAM workload identity support for GCP targets on GKE. As a part of this update, the targets' specification was changed to be able to pass the required parameters and match the GCP sources' spec. Targets'
spec.credentialsJsonparameter was removed in favor ofspec.auth.serviceAccountKey. GSA and KSA values can be passed through the spec'spec.auth.gcpServiceAccountandspec.auth.kubernetesServiceAccountparams.spec.auth.kubernetesServiceAccountis optional and the controller will create either a new KSA (with a generated name if the attribute is not passed) or re-use existing if it is available.Examples
Old target spec:
New equal version:
IAM identity:
-controller will create KSA with generated name and annotate it with IAM SA value
-if KSA
triggermesh-targetsdoes not exist, the controller will create it and annotate it with the GSA value. Otherwise, it will assign existing KSA to the component's pod.-the controller will assign this KSA to the component's pod without the reconciliation.