This repository was archived by the owner on Nov 5, 2024. It is now read-only.
Azure Service Bus Source - Concurrency#1452
Merged
Merged
Conversation
odacremolbap
approved these changes
Jun 26, 2023
odacremolbap
left a comment
odacremolbap
left a comment
Member
There was a problem hiding this comment.
On a side note, we should consider upgrading go to 1.20 for bettwe multiple error management.
|
Thanks for the approval! |
Contributor
|
@FranBarrera I'm seeing very minimal documentation in the auto-generated reference docs:
IMO we should try to keep this as descriptive as possible so it can really serve as a reference point if ever things aren't documented elsewhere. Would that be a PR on the OAS or does it go in the code? |
Contributor
|
FYI small doc update: triggermesh/docs@5e9174e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add concurrency to Azure Service Bus Source to allow more RPS.