Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Add session token support to AWS components#1446

Merged
tzununbekov merged 2 commits into
mainfrom
aws-session-token
Jun 14, 2023
Merged

Add session token support to AWS components#1446
tzununbekov merged 2 commits into
mainfrom
aws-session-token

Conversation

@tzununbekov

@tzununbekov tzununbekov commented Jun 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds AWS Sources and Targets support for temporary credentials through the introduction of sessionToken parameter in AWS auth object. Requested in #1440.

Temporary credentials can be requested with AWS CLI:

$ aws sts get-session-token

{
    "Credentials": {
        "AccessKeyId": "redacted",
        "SecretAccessKey": "redacted",
        "SessionToken": "redacted",
        "Expiration": "2023-06-07T21:25:54+00:00"
    }
}

AccessKeyId, SecretAccessKey, and SessionToken from the response can be used in the auth spec "as is" to gain temporary access to the AWS API.

@tzununbekov tzununbekov self-assigned this Jun 6, 2023
@tzununbekov tzununbekov requested a review from a team June 7, 2023 10:14
@tzununbekov tzununbekov marked this pull request as ready for review June 7, 2023 10:15
@sebgoa sebgoa mentioned this pull request Jun 7, 2023
Closed
@tzununbekov

tzununbekov commented Jun 13, 2023

Copy link
Copy Markdown
Member Author

@triggermesh/engineering can someone please review this? We should not ask users to test our dev branches for us as there is no documented and clear path to do that. Thank you.

@tzununbekov tzununbekov merged commit 9816010 into main Jun 14, 2023
@tzununbekov tzununbekov deleted the aws-session-token branch June 14, 2023 10:38
@tzununbekov tzununbekov mentioned this pull request Jun 21, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@FranBarrera FranBarrera FranBarrera approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tzununbekov tzununbekov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tzununbekov @FranBarrera