Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Differentiate GCS event types#1425

Merged
tzununbekov merged 1 commit into
mainfrom
gcs-notifications
May 18, 2023
Merged

Differentiate GCS event types#1425
tzununbekov merged 1 commit into
mainfrom
gcs-notifications

Conversation

@tzununbekov

@tzununbekov tzununbekov commented May 17, 2023

Copy link
Copy Markdown
Member

This PR introduces new event processor for GCS source that should address two issues:

  1. For CE format consistency, Pub/sub payload attributes removed from the event context, closes Can we remove CloudEvent extension attributes from the GCS source events?  #1387
  2. Produced CE types changed from generic com.google.cloud.storage.notification to one of event-specific types, resolves GCS source should produce distinct event types #1419

@tzununbekov tzununbekov self-assigned this May 17, 2023
@tzununbekov tzununbekov marked this pull request as ready for review May 17, 2023 05:08
@tzununbekov tzununbekov force-pushed the gcs-notifications branch 2 times, most recently from 2e0295e to be31878 Compare May 17, 2023 06:01
@tzununbekov tzununbekov requested a review from a team May 17, 2023 06:25
Comment thread config/300-googlecloudstoragesource.yaml
@tzununbekov tzununbekov merged commit d7e9241 into main May 18, 2023
@tzununbekov tzununbekov deleted the gcs-notifications branch May 18, 2023 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCS source should produce distinct event types Can we remove CloudEvent extension attributes from the GCS source events?

2 participants