Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Add support for Azure ServiceBus Target#1410

Merged
FranBarrera merged 9 commits into
triggermesh:mainfrom
FranBarrera:azure-servicebus-target
May 8, 2023
Merged

Add support for Azure ServiceBus Target#1410
FranBarrera merged 9 commits into
triggermesh:mainfrom
FranBarrera:azure-servicebus-target

Conversation

@FranBarrera

@FranBarrera FranBarrera commented May 3, 2023

Copy link
Copy Markdown
Contributor

Closes #1399
This PR adds support for Azure Service Bus Target.
Include support for azure service bus topic and queue

@FranBarrera FranBarrera self-assigned this May 3, 2023
@FranBarrera FranBarrera marked this pull request as ready for review May 3, 2023 09:09
@FranBarrera FranBarrera requested a review from a team May 3, 2023 09:10

@odacremolbap odacremolbap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good.
Added some nits.

Comment thread cmd/azureservicebustarget-adapter/main.go Outdated
Comment thread pkg/apis/targets/v1alpha1/azureservicebus_types.go
Comment thread pkg/apis/targets/v1alpha1/azureservicebus_types.go
Comment thread pkg/targets/adapter/azureservicebustarget/adapter.go Outdated
Comment thread pkg/targets/reconciler/azureservicebustarget/adapter.go Outdated
@FranBarrera FranBarrera requested a review from odacremolbap May 8, 2023 14:42
@FranBarrera FranBarrera merged commit 1b99824 into triggermesh:main May 8, 2023
@FranBarrera FranBarrera deleted the azure-servicebus-target branch May 8, 2023 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for AzureServiceBus as a target

2 participants