feat: suport annotations in the adapter override spec#1395
Conversation
|
I didn't see any specific tests for these files (but I'm happy to add them if they are just structured differently). |
|
Hey @knechtionscoding, thanks for the contribution! diff --git a/hack/crd-update/crd-update.py b/hack/crd-update/crd-update.py
index 6f78d5a4..855dc14b 100755
--- a/hack/crd-update/crd-update.py
+++ b/hack/crd-update/crd-update.py
@@ -17,6 +17,11 @@ try:
description: Kubernetes object parameters to apply on top of default adapter values.
type: object
properties:
+ annotations:
+ description: Adapter annotations.
+ type: object
+ additionalProperties:
+ type: string
labels:
description: Adapter labels.
type: objectthen run Regarding the tests. There is a totally outdated and inefficient TestAdapterOverrideOptions, and we need to make it relevant someday, meanwhile, the easy path is to add (Pod)Annotation objectOption in deployment_test.go and knservice_test.go to validate its effect on the adapter. |
|
@tzununbekov I think I've got all of that done, let me know if there's anything left! |
|
Yes, perfect! I forgot about the codegen update, so I took care of it to get this PR merged today. Thanks! |
|
Appreciate the help to get it over the finish line @tzununbekov ! |
Allows support for Annotations in the adapterOverride spec
closes #1394