Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Add support for setting adapter nodeSelector#1380

Merged
FranBarrera merged 4 commits into
triggermesh:mainfrom
FranBarrera:add-nodeselector
Mar 28, 2023
Merged

Add support for setting adapter nodeSelector#1380
FranBarrera merged 4 commits into
triggermesh:mainfrom
FranBarrera:add-nodeselector

Conversation

@FranBarrera

@FranBarrera FranBarrera commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Addresses one of the features requested in #768.

Example:

spec:
  # ...
  adapterOverrides:
    nodeSelector:
      disktype: ssd

Result:

kubectl get deployment awss3source-sample -o jsonpath='{.spec.template.spec.nodeSelector}'
{"disktype":"ssd"}

@FranBarrera FranBarrera requested a review from a team March 28, 2023 11:09
@FranBarrera FranBarrera self-assigned this Mar 28, 2023
odacremolbap
odacremolbap reviewed Mar 28, 2023
View reviewed changes

@odacremolbap odacremolbap left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested by the action output, can you you did it before I wrote this ...

hack/crd-update/update-all-crds.sh

Comment thread pkg/reconciler/resource/deployment_test.go
@odacremolbap odacremolbap self-requested a review March 28, 2023 11:30
odacremolbap
odacremolbap approved these changes Mar 28, 2023
View reviewed changes

@odacremolbap odacremolbap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy when CI is happy.

@FranBarrera FranBarrera merged commit bc1032f into triggermesh:main Mar 28, 2023
@FranBarrera FranBarrera deleted the add-nodeselector branch March 28, 2023 14:24
@sebgoa sebgoa mentioned this pull request May 16, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@odacremolbap odacremolbap odacremolbap approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@FranBarrera FranBarrera

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FranBarrera @odacremolbap