Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

GCP Cloud Services - Custom KSA Names#1372

Merged
tzununbekov merged 6 commits into
triggermesh:mainfrom
coding-trees:workload-identity-custom-ksa
Mar 31, 2023
Merged

GCP Cloud Services - Custom KSA Names#1372
tzununbekov merged 6 commits into
triggermesh:mainfrom
coding-trees:workload-identity-custom-ksa

Conversation

@coding-trees

Copy link
Copy Markdown
Contributor

Adding new kubernetesServiceAccount field that when set will be the name of the KSA created. As suggested, made changes to ServiceAccountOptions. I noticed that Workload Identity was only implemented in the sources for GCP Cloud services, but let me know if I missed anything.

These changes address feature request outlined in #1371

@tzununbekov tzununbekov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @coding-trees!
There are a couple of things that need to be addressed before merging this PR. Feel free to comment if there are any questions or if I missed something in the review.

Comment thread config/300-googlecloudauditlogssource.yaml Outdated
Comment thread pkg/apis/common/v1alpha1/gcp_types.go Outdated
@tzununbekov

tzununbekov commented Mar 30, 2023

Copy link
Copy Markdown
Member

@coding-trees there are a couple of CI jobs that failed, but should be easy to fix:

hack/crd-update/update-all-crds.sh

-to ensure that all CRDs are formatted correctly,

make codegen

-to update autogenerated client files.

And the fix in the test related to ServiceAccount function update - the easiest way to fix that is probably to pass a mock SA object to that function in the test.

@coding-trees

Copy link
Copy Markdown
Contributor Author

@coding-trees there are a couple of CI jobs that failed, but should be easy to fix:

hack/crd-update/update-all-crds.sh

-to ensure that all CRDs are formatted correctly,

make codegen

-to update autogenerated client files.

And the fix in the test related to ServiceAccount function update - the easiest way to fix that is probably to pass a mock SA object to that function in the test.

Thanks for the tips, I was able to fix the tests and CRDs however when I ran make codegen it resulted in deleting ~903 files :0

image

Doesn't seem right so I didn't commit it - maybe I'm doing something wrong?

@tzununbekov

Copy link
Copy Markdown
Member

@coding-trees there are a couple of CI jobs that failed, but should be easy to fix:

hack/crd-update/update-all-crds.sh

-to ensure that all CRDs are formatted correctly,

make codegen

-to update autogenerated client files.
And the fix in the test related to ServiceAccount function update - the easiest way to fix that is probably to pass a mock SA object to that function in the test.

Thanks for the tips, I was able to fix the tests and CRDs however when I ran make codegen it resulted in deleting ~903 files :0

image

Doesn't seem right so I didn't commit it - maybe I'm doing something wrong?

Yeah, something is off with the codegen paths, I took care of it.

@tzununbekov tzununbekov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coding-trees thank you for the contribution 👍

@tzununbekov tzununbekov merged commit e02349b into triggermesh:main Mar 31, 2023
@coding-trees

Copy link
Copy Markdown
Contributor Author

Thank you for all the help @tzununbekov

@coding-trees coding-trees deleted the workload-identity-custom-ksa branch April 3, 2023 19:04
sameersbn pushed a commit that referenced this pull request Apr 5, 2023
* Adding custom kubernetes service name to gcp cloud sources
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants