GCP Cloud Services - Custom KSA Names#1372
Conversation
tzununbekov
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @coding-trees!
There are a couple of things that need to be addressed before merging this PR. Feel free to comment if there are any questions or if I missed something in the review.
|
@coding-trees there are a couple of CI jobs that failed, but should be easy to fix: -to ensure that all CRDs are formatted correctly, -to update autogenerated client files. And the fix in the test related to |
Thanks for the tips, I was able to fix the tests and CRDs however when I ran Doesn't seem right so I didn't commit it - maybe I'm doing something wrong? |
Yeah, something is off with the codegen paths, I took care of it. |
tzununbekov
left a comment
There was a problem hiding this comment.
@coding-trees thank you for the contribution 👍
|
Thank you for all the help @tzununbekov |
* Adding custom kubernetes service name to gcp cloud sources

Adding new
kubernetesServiceAccountfield that when set will be the name of the KSA created. As suggested, made changes toServiceAccountOptions. I noticed that Workload Identity was only implemented in the sources for GCP Cloud services, but let me know if I missed anything.These changes address feature request outlined in #1371