This repository was archived by the owner on Nov 5, 2024. It is now read-only.
Reconciling ServiceAccounts improvements#1354
Merged
odacremolbap merged 1 commit intoMar 8, 2023
Merged
Conversation
tzununbekov
approved these changes
Mar 8, 2023
odacremolbap
pushed a commit
that referenced
this pull request
Mar 8, 2023
(cherry picked from commit db0323b)
sameersbn
pushed a commit
that referenced
this pull request
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServiceAccounts reconciliation might happen more often than needed, and might also remove externally added secrets.
Fixes:
Multitenant components will add a list of owners to the
ServiceAccount. If the owner list composed at the TriggerMesh controller does not match the order in which the list already exist, it will trigger a reconciliation. We are ordering the owner list by name to make sure that we don't trigger more syncs than we need.Some environments are configured to automatically add
SecretsorImagePullSecretstoServiceAccounts. A reconciliation would make suchServiceAccountsremoveImagePullSecretsandSecretswhose pattern are not those of a kubernetes token.