fix(sdk): drop duplicate onError on SSE auth-error path

ericallam · ericallam · commit d1b27a971a51 · 2026-05-05T18:14:56.000+01:00
`SSEStreamSubscription.connectStream` invokes `onError` twice for 401/403
responses: first in the `!response.ok` branch where the auth ApiError is
constructed (so consumers see the original failure status/headers), then
again in the catch block's `isTriggerRealtimeAuthError` arm before
terminating the stream. Drop the second call — the early one already
notified the consumer; the catch block's job is just to route the error
to `controller.error` so retry doesn't fire.

Spotted by Devin on PR 3173.
diff --git a/packages/core/src/v3/apiClient/runStream.ts b/packages/core/src/v3/apiClient/runStream.ts
@@ -431,7 +431,9 @@ export class SSEStreamSubscription implements StreamSubscription {
       }
 
       if (isTriggerRealtimeAuthError(error)) {
-        this.options.onError?.(error as Error);
+        // `onError` was already invoked in the `!response.ok` branch above
+        // (where the auth ApiError was originally constructed and thrown).
+        // Auth errors are non-retryable: terminate the stream cleanly.
         controller.error(error as Error);
         return;
       }

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,9 @@ export class SSEStreamSubscription implements StreamSubscription {`
`431`	`431`	`}`
`432`	`432`
`433`	`433`	`if (isTriggerRealtimeAuthError(error)) {`
`434`		`- this.options.onError?.(error as Error);`
	`434`	+ // `onError` was already invoked in the `!response.ok` branch above
	`435`	`+ // (where the auth ApiError was originally constructed and thrown).`
	`436`	`+ // Auth errors are non-retryable: terminate the stream cleanly.`
`435`	`437`	`controller.error(error as Error);`
`436`	`438`	`return;`
`437`	`439`	`}`