fix pathspec version requirement #10948
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10948 +/- ##
==========================================
+ Coverage 90.68% 90.97% +0.29%
==========================================
Files 504 505 +1
Lines 39795 41022 +1227
Branches 3141 3244 +103
==========================================
+ Hits 36087 37321 +1234
- Misses 3042 3063 +21
+ Partials 666 638 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skshetry
approved these changes
Jan 6, 2026
Collaborator
skshetry
left a comment
skshetry
left a comment
There was a problem hiding this comment.
Thank you for contributing and bringing the issue to my attention. I’d like to support the new version, but it seems that would require a substantial change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pathspec v1 has been released, and with current DVC dependency setup it gets installed by default. However, Pathspec v1 is not compatible with current DVC, which causes DVC to fail with the following error:
unexpected error - cannot import name '_DIR_MARK' from 'pathspec.patterns.gitwildmatch' (/path/to/lib/python3.10/site-packages/pathspec/patterns/gitwildmatch.py)This PR prevents the issue by explicitly pinning pathspec to
<1, ensuring a compatible version is installed and DVC works as expected.