Skip to content

[ci skip] for pull request #5374

Open
Open

Description

@mathieujobin

[ci skip] is very useful per commit. but sometimes you want to open a pull request early for review but you are not necessarely ready to run the tests right away

if I could add [ci skip] to my PR title it would be perfect
when I am ready, I am simply taking it out. I might need to close and reopen the PR but I am fine with that. I am already doing it as a trick to rerun the pull request against updated master ;)

cheers,

Activity

  1. BanzaiMan commented on Dec 30, 2015

    @BanzaiMan
    Contributor

    How do you expect maintainers of the upstream project to evaluate the PR without actually running the build?

  2. Joshua-Anderson commented on Dec 30, 2015

    @Joshua-Anderson

    This could be useful for documentation PRs. Many projects have required commit formats, so it's not possible to add a [ci skip] to the commit itself.

  3. mathieujobin commented on Dec 30, 2015

    @mathieujobin
    Author

    the idea is to have a code review from your peers, before it is ready to be sent to the CI server, especially for projects with a lot of tests and especially because every commits trigger two build.

    once the submitter is ready to have the test being run by travis, he can edit the PR title to remove the [ci skip] tag and click close/reopen the PR to trigger the build

    I'm not sure If I am describing this better this time ?

  4. kbrock commented on Jan 7, 2016

    @kbrock

    @BanzaiMan
    How do you expect maintainers of the upstream project to evaluate the PR without actually running the build?

    Currently, a person submitting a PR is able to skip a build by putting [ci skip] into all the commits. So allowing them to put that same phrase into the PR text is granting them no more or less power.

    This is nice because the maintainers can edit the title, remove [ci skip], and trigger a build. If that text were in the commits themselves, only the submitter can trigger a build, not the maintainer.

  5. joshk commented on Jan 7, 2016

    @joshk
    Contributor

    I'm sorry but we don't check the PR title for testability.

    I do understand the point, and how this might be useful.

    We will have a think about this, but I do not have an ETA on if or when we will make a decision.

  6. cmw commented on Jan 25, 2016

    @cmw

    @joshk We have a use case where this is useful, as we start PRs in our github immediately to have access to the comment section for discussion purposes. We currently flag those [WIP] so we know not to care about CI status etc yet, but pushes to those PRs keep clogging up our travis workers. A way to skip those branches would be great for our deploy pipeline.

  7. rameshthoomu commented on Mar 9, 2016

    @rameshthoomu

    @joshk : I have a scenario where i want to skip the PR for document change or for small code correction where the build deployment and further tests are not required. Could you please give me a solution how to skip when some sends a PR against the Document changes. thanks in advance!!

  8. se7entyse7en commented on Apr 29, 2016

    @se7entyse7en

    @joshk I have a similar use case to that exposed by @cmw

  9. sbts commented on Apr 30, 2016

    @sbts

    We also have a similar use case, updates to scripts and docs that don't affect anything in the testable code shouldn't need to trigger a travis build and test. (our main project is a perl project where we use travis to run our test suite, but there is nothing for travis to actually build.

  10. akien-mga commented on Jun 19, 2016

    @akien-mga

    I'd also like to have this feature, especially for documentation updates as other mentioned, or when adding icons, moving scripts around... basically anything that does not impact the buildsystem.

    I like to keep my git history clean, and adding [ci skip] to all such commit logs is far from optimal; 2 years from now, when I read the git history, I don't really need to know that the CI was skipped for this specific commit. That's why I'd like to be able to keep this kind of metadata in GitHub's PR system, so that I can get the feature without touching the git history.

  11. ehuelsmann commented on Jul 18, 2016

    @ehuelsmann

    Same here.

  12. jakirkham commented on Oct 31, 2016

    @jakirkham

    So I actually strongly dislike this idea and would like to elucidate why.

    One of the use cases one of my orgs has is running CI on the PR, but not on the merge commit. In these cases, what we want to do is have the title include [ci skip] as that will get included in the merge commit automatically when merging. This way the commits in the PR can be verified to be working before the merge. Then after merging we simply skip the Travis CI build.

    Having titles included as part of CI build determination for the PR would actually break our use case.

  13. mathieujobin commented on Nov 1, 2016

    @mathieujobin
    Author

    @jakirkham skipping merge commit on master is a wrong idea.
    even if the PR build passed, unless you force your branch to be up to date before merge, you are taking a chance to introduce incompatibilities between merges

  14. jakirkham commented on Nov 1, 2016

    @jakirkham

    Not really @mathieujobin as Travis CI tests the merge commit that GitHub creates by "merging" with the base branch. The quotes are not to suggest it isn't a real merge, but merely to suggest the PR itself is still not yet merged.

    In general, if you are concerned about the testing being stale (e.g. other things got merged first), then yes you will either need to close/reopen the PR to make GitHub generate a new merge ref or you need to update your PR by merging/rebasing with the base branch. However, I don't see this as a fundamental problem of my use case. Instead this is a problem with merging PRs with stale CI results regardless of the reason. However, if you do have truly orthogonal unit tests, this is very rarely any practical concern.

  15. 6 remaining items

  16. mathieujobin commented on Nov 5, 2016

    @mathieujobin
    Author

    Correct. Only sometimes we want to do this.

    @jakirkham this feature won't even break your use case.

    you simply have to not use the [ci skip] while the PR is open, being reviewed and evolving into the most beautiful piece of art... making sure tests are passing and all.

    Then just before merging, you rename the PR to include that flag, hit merge. and you won't get that extra build on travis.

    it is the exact opposite of my use case, where I want to use this [ci skip] tag while the PR is in early review and I don't want to trigger a hour long build when I know I am not done. Then, once I am ready, I take it out of the PR title. and things resume as ordinary.

    See everyone is happy, thank you Travis !

  17. kbrock commented on Nov 5, 2016

    @kbrock

    @mathieujobin actually - it isn't even that complex.
    You can just edit the message right before the merge.

    But that is something that the merger needs to remember to do.
    Easier to have the subject reflect what is going to happen.

  18. mathieujobin commented on Nov 7, 2016

    @mathieujobin
    Author

    You can just edit the message right before the merge.

    this is exactly what I was saying

  19. bootstraponline commented on Jan 4, 2017

    @bootstraponline

    FYI bitrise has shipped [ci skip] in PR titles and it's awesome. Would be nice for Travis to do the same.

  20. JustArchi commented on Jan 6, 2017

    @JustArchi

    I have another use case for this - I'm using crowdin for GitHub integration which automatically maintains l10n branch and opens pull request targetting master, which I can merge when I feel like releasing next version. This PR is constantly being updated with new commits, and once last one is merged, new one is being opened.

    I already excluded l10n branch from building in travis, but commits are fully automatic, meaning I don't have direct access to alter them. By marking this automatic PR with [ci skip] I'd stop trashing your servers with massive amount of commit build requests that do not make any sense, as every commit is small text change provided by upstream (so it can't even break the build, I'm building C# and strings are totally optional to be included or not).

    So I'd also appreciate [ci skip] for PR title, as it'd benefit both you and me, but you more, as it doesn't matter that much for me whether those commits are queued up or not. Please 👍

  21. chambm commented on Sep 1, 2017

    @chambm

    I'd like to use this for skipping CI when making a pull request against another project's README.md. No reason to run tests for that...

  22. stale commented on Apr 13, 2018

    @stale

    Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

  23. ehuelsmann commented on Apr 13, 2018

    @ehuelsmann
  24. kbrock commented on Apr 16, 2018

    @kbrock

    @ehuelsmann Nah. I know we still desire this.

    From what I could tell, only the git commit messages are inspected, and the github title is not. Making this technically difficult since more data would need to flow down to travis.

    Also, when it comes down to implementation, there are a few nuances that different users want implemented differently. Making it even less straightforward.

    Thank you @joshk and travis team for considering it.

  25. disha94 commented on May 20, 2019

    @disha94

    @mathieujobin this can be achieved in a different way too.
    Travis provides these set of conditions for running conditional builds: https://docs.travis-ci.com/user/conditions-v1
    You can use "commit-message" condition and then travis builds will only run if your commit has that regex present.
    I have tried this out and it works as expected.

  26. bmitchinson commented on Mar 13, 2020

    @bmitchinson

    Still would like to see this for work in progress PRs.

  27. iamareebjamal commented on Mar 27, 2020

    @iamareebjamal

    Maybe a PR label would be a better option

  28. cpettet commented on Jan 19, 2022

    @cpettet

    My team would like to see this for WIP PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions