Skip to content

Fuzz test for compact.RangeNodes#32

Merged
mhutchinson merged 6 commits intotransparency-dev:mainfrom
hickford:fuzz
Jul 21, 2022
Merged

Fuzz test for compact.RangeNodes#32
mhutchinson merged 6 commits intotransparency-dev:mainfrom
hickford:fuzz

Conversation

@hickford
Copy link
Copy Markdown
Contributor

@hickford hickford commented Jul 18, 2022

@hickford hickford requested a review from a team as a code owner July 18, 2022 15:22
@hickford hickford requested a review from AlCutter July 18, 2022 15:22
@hickford
Copy link
Copy Markdown
Contributor Author

hickford commented Jul 18, 2022 •
edited
Loading

Requires https://pkg.go.dev/testing#F "added in go1.18", so would need to adjust CI

AlCutter
AlCutter reviewed Jul 18, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

@hickford hickford requested a review from AlCutter July 18, 2022 15:35
mhutchinson
mhutchinson approved these changes Jul 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This with the changes @AlCutter has done to put the new features behind a build flag so that we're still compatible with 1.17 looks very tasty to me. Good work, team.

@AlCutter
Copy link
Copy Markdown
Collaborator

AlCutter commented Jul 20, 2022

I've added a couple of commits for discussion:

  • Move the fuzz test into its own file, guarded by a build tag which only allows go1.18+ to see it
  • Rolled back the test/CI config changes to allow testing with 1.17 and 1.18

@hickford What do you think?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #32 (0186e47) into main (3d7510c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files           7        7           
  Lines         497      497           
=======================================
  Hits          442      442           
  Misses         50       50           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7510c...0186e47. Read the comment docs.

@mhutchinson mhutchinson mentioned this pull request Jul 20, 2022
Merged
@hickford
Copy link
Copy Markdown
Contributor Author

hickford commented Jul 21, 2022

@AlCutter LGTM

@mhutchinson mhutchinson merged commit ca422cf into transparency-dev:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

@AlCutter AlCutter AlCutter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hickford @AlCutter @codecov-commenter @mhutchinson