Repository navigation
Fix the both-null guard in SorterBase to test the right-hand side - #9098
Merged
Merged
Conversation
ckerr
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
SorterBase<T>::compare_vfuncthe "both sides failed to cast" guard testsconcrete_lhstwice, so it never looks at the right side at all. The twog_return_val_if_faillines under it are written to separate the one-sided cases, and the first of them can't be reached the way it stands: withconcrete_lhsnull andconcrete_rhsfine, the guard already fired and returnedEQUALinstead ofSMALLER.This only shows up on the GTK4 path when
Glib::wrap_autohands back something that isn't aT, which is why nothing has complained about it. The names sit next to each other on consecutive lines, which is probably how it happened.