Add labels feature #822

qu1ck · 2019-01-26T08:13:57Z

Adds ability to add arbitrary labels to torrents.
Torrents can be marked for example as "iso", "linux", "debian" or any combination of those labels at the same time. Front ends can then implement filtering by those labels, see this example implementation.

ckerr

Thanks for this PR!

This looks like a good start. There's still the open question of how to integrate the existing Mac client's labels into this, and how the non-Mac clients should make use of this, but that doesn't block adding the functionality to libtransmission.

Comments inline

libtransmission/torrent.h

libtransmission/ptrarray.c

utils/remote.c

libtransmission/torrent.c

libtransmission/rpcimpl.c

utils/remote.c

qu1ck

Thanks for fantastic comments. I think I addressed them all, please take another look.

utils/remote.c

libtransmission/rpcimpl.c

mikedld · 2019-02-04T05:51:01Z

utils/remote.c

+{
+    tr_variant* labels = tr_variantDictAddList(args, key, 100);
+    char const* token;
+    while ((token = tr_strsep(&arg, ", ")) != NULL)


tr_strsep takes a char** while you're passing char const** here. I'd like to raise this (and all the other non-deprecation warnings) to an error at some point (for CI builds only), but currently compilers issue a warning, so please pay attention to it:

.../utils/remote.c: In function ‘addLabels’: .../utils/remote.c:654:31: warning: passing argument 1 of ‘tr_strsep’ from incompatible pointer type [-Wincompatible-pointer-types] while ((token = tr_strsep(&arg, ", ")) != NULL) ^ In file included from .../libtransmission/crypto-utils.h:16:0, from .../utils/remote.c:22: .../libtransmission/utils.h:243:7: note: expected ‘char **’ but argument is of type ‘const char **’ char* tr_strsep(char** str, char const* delim); ^~~~~~~~~

The reason for this is that tr_strsep modifies the input string by replacing a found delimiter character with a '\0' (null) character on each successful call.

I fixed it by creating temporary copy of arg. Let me know if you had something different in mind.

libtransmission/rpcimpl.c

utils/remote.c

mikedld · 2019-02-04T06:18:19Z

libtransmission/rpcimpl.c

+    for (i = 0; i < n; i++)
+    {
+        if (tr_variantGetStr(tr_variantListChild(list, i), &str, &str_len) && str && str_len)
+            tr_ptrArrayAppend(&tor->labels, tr_strndup (str, str_len));


Since we're allowing the use of ',' (comma) and ' ' (space) as label separators, need to validate the input here to make sure those characters aren't part of one of the list values.

At first I used space as another separator to automatically trim extra space from labels but now I realized that will prevent space in middle of the label as well, which was not my intention.
Now only comma is considered a separator and I do tr_strstrip() in remote.c.

Also added validation as requested.

mikedld · 2019-02-04T06:33:56Z

... There's still the open question of how to integrate the existing Mac client's labels into this ...

I believe "labels" (here; multiple per torrent) and "groups" (Mac client; one per torrent) should be separate things. The former is not required to be unique and may not even have the associated settings with it (thus storing it in .resume, not settings.json or other global file, is enough), while the latter is used to potentially assign some settings to a torrent. Whether "group" needs to be a special case of "label" or not is a separate discussion.

qu1ck

Addressed comments, PTAL.

qu1ck · 2019-02-04T11:21:59Z

Btw failure in MacOS build is a flake, I'm not sure if I can do anything about it.

mikedld · 2019-02-04T12:04:41Z

Btw failure in MacOS build is a flake, I'm not sure if I can do anything about it.

Looks like updating to Xcode 10 led to more than 1.5x build slowdown (seen in quarter range)... I've adjusted the timeout to 20 minutes and restarted the build. Irrelevant to this PR indeed.

qu1ck · 2019-02-10T02:38:17Z

Friendly ping to reviewers.

ckerr

Gave another review pass for the new ptrarray code. Thanks for those changes!

libtransmission/resume.c

libtransmission/rpcimpl.c

ckerr · 2019-02-10T22:12:30Z

utils/remote.c


+static void addLabels(tr_variant* args, const tr_quark key, const char* arg)
+{
+    tr_variant* labels = tr_variantDictAddList(args, key, 100);


preallocating 100 label slots seems like a lot?

I believe original author copied this from function below but 100 files is definitely more likely than 100 labels. I changed this to 10, does this work better?

utils/remote.c

ckerr · 2019-02-10T22:22:56Z

libtransmission/ptrarray.h

 /** @brief Return the nth item in a tr_ptrArray
    @return the nth item in a tr_ptrArray */
-static inline void* tr_ptrArrayNth(tr_ptrArray* array, int i)
+static inline void* tr_ptrArrayNth(const tr_ptrArray* array, int i)


Leaving this as non-const was intentional because the return value isn't const.

If you're trying to do this to loop through a const array of labels, check out how tr_ptrArrayBase() is used e.g. in session.c:

if (!tr_ptrArrayEmpty(&loadme)) { int const n = tr_ptrArraySize(&loadme); char const* const* paths = (char const* const*)tr_ptrArrayBase(&loadme); for (int i = 0; i < n; ++i) { tr_list_append(&blocklists, tr_blocklistFileNew(paths[i], isEnabled)); } }

Thanks for the suggestion, yes that was my intent.

libtransmission/torrent.h

qu1ck

Thanks for review, I addressed the comments.

qu1ck · 2019-02-11T02:25:15Z

libtransmission/ptrarray.h

 /** @brief Return the nth item in a tr_ptrArray
    @return the nth item in a tr_ptrArray */
-static inline void* tr_ptrArrayNth(tr_ptrArray* array, int i)
+static inline void* tr_ptrArrayNth(const tr_ptrArray* array, int i)


Thanks for the suggestion, yes that was my intent.

libtransmission/torrent.h

qu1ck · 2019-02-11T02:32:09Z

utils/remote.c


+static void addLabels(tr_variant* args, const tr_quark key, const char* arg)
+{
+    tr_variant* labels = tr_variantDictAddList(args, key, 100);


I believe original author copied this from function below but 100 files is definitely more likely than 100 labels. I changed this to 10, does this work better?

ckerr · 2019-02-11T15:19:04Z

@mikedld can you take another look?

libtransmission/resume.c

libtransmission/rpcimpl.c

utils/remote.c

mikedld

@ckerr I'm mostly satisfied, back to you.

utils/remote.c

libtransmission/rpcimpl.c

qu1ck · 2019-02-16T06:36:39Z

Thanks for thorough review Mike. I think I addressed everything except the comment you had about potential memory leak in torrentSet/setLabels. I didn't understand where was the leak, could you check if it's still there and elaborate a bit how it happens?
I think reusing same tr_variant* for labels and files was not an issue otherwise there would be lots of mem leaks as other such variables are also reused later in torrentSet(). Am I missing something?

mikedld · 2019-02-16T06:45:57Z

Yeah, that memory leak comment was bogus, I removed it since then, sorry.

mikedld · 2019-02-16T06:52:05Z

libtransmission/rpcimpl.c

+                errmsg = "labels cannot be empty";
+            }
+
            if (strchr(str, ',') != NULL)


Minor, but I'd stop on the first error we get, i.e.

Suggested change

if (strchr(str, ',') != NULL)

if (errmsg != NULL && strchr(str, ',') != NULL)

Same below: could wrap following for and if in if (errmsg != NULL) as well.

Looks like I'm an idiot once again. It should've been errmsg == NULL :)

…andi/labels to official transmission repo

Changed `tr_ptrArray* labels` to `tr_ptrArray labels`; Removed tr_ptrArrayNew() tr_ptrArrayDup() tr_ptrArrayFree() Use tr_strsep() to split string by delimiters Update transmission-remote.1 Update rpc-spec.txt

Use uncrustify to format changed files Fix "const <type>" -> "<type> const" Fix small comments

qu1ck · 2019-02-16T11:54:31Z

Looks like I need to rebase again. I'll take this chance to squash some commits to cleanup history.

ckerr

LGTM. Thanks for addressing all the feedback!

nukejello · 2019-02-23T04:39:33Z

Thank you for adding this!

ronggang · 2019-03-06T00:56:34Z

Good job. 👍👍

Belphemur · 2019-03-30T15:23:00Z

@qu1ck I know this PR is merged, but I would like to know if you could do another one to add:

An ENV VAR like TR_TORRENT_LABELS into

transmission/libtransmission/torrent.c

Line 2234 in d3b8982

static void torrentCallScript(tr_torrent const* tor, char const* script)

that would contain a string with all the labels comma separated.

Because right now, you can only get the labels through the rpc which would mean having the script getting the info on the torrent to get the labels.

I would love to add it myself if I'm given pointer on how to concatenate a tr_variantListStr.

### All Platforms - Allow the RPC server to listen on an IPv6 address ([#161](transmission/transmission#161)) - Change `TR_CURL_SSL_VERIFY` to `TR_CURL_SSL_NO_VERIFY` and enable verification by default ([#334](transmission/transmission#334)) - Go back to using hash as base name for resume and torrent files (those stored in configuration directory) ([#122](transmission/transmission#122)) - Handle "fields" argument in "session-get" RPC request; if "fields" array is present in arguments, only return session fields specified; otherwise return all the fields as before - Limit the number of incorrect authentication attempts in embedded web server to 100 to prevent brute-force attacks ([#371](transmission/transmission#371)) - Set idle seed limit range to 1..40320 (4 weeks tops) in all clients ([#212](transmission/transmission#212)) - Add Peer ID for Xfplay, PicoTorrent, Free Download Manager, Folx, Baidu Netdisk torrent clients ([#256](transmission/transmission#256), [#285](transmission/transmission#285), [#355](transmission/transmission#355), [#363](transmission/transmission#363), [#386](transmission/transmission#386)) - Announce `INT64_MAX` as size left if the value is unknown (helps with e.g. Amazon S3 trackers) ([#250](transmission/transmission#250)) - Add `TCP_FASTOPEN` support (should result in slight speedup) ([#184](transmission/transmission#184)) - Improve ToS handling on IPv6 connections ([#128](transmission/transmission#128), [#341](transmission/transmission#341), [#360](transmission/transmission#360), [#692](transmission/transmission#692), [#737](transmission/transmission#737)) - Abort handshake if establishing DH shared secret fails (leads to crash) ([#27](transmission/transmission#27)) - Don't switch trackers while announcing (leads to crash) ([#297](transmission/transmission#297)) - Improve completion scripts execution and error handling; add support for .cmd and .bat files on Windows ([#405](transmission/transmission#405)) - Maintain a "session ID" file (in temporary directory) to better detect whether session is local or remote; return the ID as part of "session-get" response (TRAC-5348, [#861](transmission/transmission#861)) - Change torrent location even if no data move is needed ([#35](transmission/transmission#35)) - Support CIDR-notated blocklists ([#230](transmission/transmission#230), [#741](transmission/transmission#741)) - Update the resume file before running scripts ([#825](transmission/transmission#825)) - Make multiscrape limits adaptive ([#837](transmission/transmission#837)) - Add labels support to libtransmission and transmission-remote ([#822](transmission/transmission#822)) - Parse `session-id` header case-insensitively ([#765](transmission/transmission#765)) - Sanitize suspicious path components instead of rejecting them ([#62](transmission/transmission#62), [#294](transmission/transmission#294)) - Load CA certs from system store on Windows / OpenSSL ([#446](transmission/transmission#446)) - Add support for mbedtls (formely polarssl) and wolfssl (formely cyassl), LibreSSL ([#115](transmission/transmission#115), [#116](transmission/transmission#116), [#284](transmission/transmission#284), [#486](transmission/transmission#486), [#524](transmission/transmission#524), [#570](transmission/transmission#570)) - Fix building against OpenSSL 1.1.0+ ([#24](transmission/transmission#24)) - Fix quota support for uClibc-ng 1.0.18+ and DragonFly BSD ([#42](transmission/transmission#42), [#58](transmission/transmission#58), [#312](transmission/transmission#312)) - Fix a number of memory leaks (magnet loading, session shutdown, bencoded data parsing) ([#56](transmission/transmission#56)) - Bump miniupnpc version to 2.0.20170509 ([#347](transmission/transmission#347)) - CMake-related improvements (Ninja generator, libappindicator, systemd, Solaris and macOS) ([#72](transmission/transmission#72), [#96](transmission/transmission#96), [#117](transmission/transmission#117), [#118](transmission/transmission#118), [#133](transmission/transmission#133), [#191](transmission/transmission#191)) - Switch to submodules to manage (most of) third-party dependencies - Fail installation on Windows if UCRT is not installed ### Mac Client - Bump minimum macOS version to 10.10 - Dark Mode support ([#644](transmission/transmission#644), [#722](transmission/transmission#722), [#757](transmission/transmission#757), [#779](transmission/transmission#779), [#788](transmission/transmission#788)) - Remove Growl support, notification center is always used ([#387](transmission/transmission#387)) - Fix autoupdate on High Sierra and up by bumping the Sparkle version ([#121](transmission/transmission#121), [#600](transmission/transmission#600)) - Transition to ARC ([#336](transmission/transmission#336)) - Use proper UTF-8 encoding (with macOS-specific normalization) when setting download/incomplete directory and completion script paths ([#11](transmission/transmission#11)) - Fix uncaught exception when dragging multiple items between groups ([#51](transmission/transmission#51)) - Add flat variants of status icons for message log ([#134](transmission/transmission#134)) - Optimize image resources size ([#304](transmission/transmission#304), [#429](transmission/transmission#429)) - Update file icon when file name changes ([#37](transmission/transmission#37)) - Update translations ### GTK+ Client - Add queue up/down hotkeys ([#158](transmission/transmission#158)) - Modernize the .desktop file ([#162](transmission/transmission#162)) - Add AppData file ([#224](transmission/transmission#224)) - Add symbolic icon variant for the Gnome top bar and when the high contrast theme is in use ([#414](transmission/transmission#414), [#449](transmission/transmission#449)) - Update file icon when its name changes ([#37](transmission/transmission#37)) - Switch from intltool to gettext for translations ([#584](transmission/transmission#584), [#647](transmission/transmission#647)) - Update translations, add new translations for Portuguese (Portugal) ### Qt Client - Bump minimum Qt version to 5.2 - Fix dropping .torrent files into main window on Windows ([#269](transmission/transmission#269)) - Fix prepending of drive letter to various user-selected paths on Windows ([#236](transmission/transmission#236), [#307](transmission/transmission#307), [#404](transmission/transmission#404), [#437](transmission/transmission#437), [#699](transmission/transmission#699), [#723](transmission/transmission#723), [#877](transmission/transmission#877)) - Fix sorting by progress in presence of magnet transfers ([#234](transmission/transmission#234)) - Fix .torrent file trashing upon addition ([#262](transmission/transmission#262)) - Add queue up/down hotkeys ([#158](transmission/transmission#158)) - Reduce torrent properties (file tree) memory usage - Display tooltips in torrent properties (file tree) in case the names don't fit ([#411](transmission/transmission#411)) - Improve UI look on hi-dpi displays (YMMV) - Use session ID (if available) to check if session is local or not ([#861](transmission/transmission#861)) - Use default (instead of system) locale to be more flexible ([#130](transmission/transmission#130)) - Modernize the .desktop file ([#162](transmission/transmission#162)) - Update translations, add new translations for Afrikaans, Catalan, Danish, Greek, Norwegian Bokmål, Slovenian ### Daemon - Use libsystemd instead of libsystemd-daemon (TRAC-5921) - Harden transmission-daemon.service by disallowing privileges elevation ([#795](transmission/transmission#795)) - Fix exit code to be zero when dumping settings ([#487](transmission/transmission#487)) ### Web Client - Fix tracker error XSS in inspector (CVE-?) - Fix performance issues due to improper use of `setInterval()` for UI refresh (TRAC-6031) - Fix recognition of `https://` links in comments field ([#41](transmission/transmission#41), [#180](transmission/transmission#180)) - Fix torrent list style in Google Chrome 59+ ([#384](transmission/transmission#384)) - Show ETA in compact view on non-mobile devices ([#146](transmission/transmission#146)) - Show upload file button on mobile devices ([#320](transmission/transmission#320), [#431](transmission/transmission#431), [#956](transmission/transmission#956)) - Add keyboard hotkeys for web interface ([#351](transmission/transmission#351)) - Disable autocompletion in torrent URL field ([#367](transmission/transmission#367)) ### Utils - Prevent crash in transmission-show displaying torrents with invalid creation date ([#609](transmission/transmission#609)) - Handle IPv6 RPC addresses in transmission-remote ([#247](transmission/transmission#247)) - Add `--unsorted` option to transmission-show ([#767](transmission/transmission#767)) - Widen the torrent-id column in transmission-remote for cleaner formatting ([#840](transmission/transmission#840))

net/transmission-gtk: security update net/transmission-qt: security update net/transmission: security update Revisions pulled up: - net/transmission-gtk/Makefile 1.46 - net/transmission-gtk/PLIST 1.2 - net/transmission-qt/Makefile 1.54 - net/transmission/Makefile 1.27 - net/transmission/Makefile.common 1.10 - net/transmission/PLIST 1.4 - net/transmission/distinfo 1.16 - net/transmission/patches/patch-qt_qtr.pro 1.7 ------------------------------------------------------------------- Module Name: pkgsrc Committed By: wiz Date: Mon Jul 13 13:01:02 UTC 2020 Modified Files: pkgsrc/net/transmission: Makefile Makefile.common PLIST distinfo pkgsrc/net/transmission-gtk: Makefile PLIST pkgsrc/net/transmission-qt: Makefile pkgsrc/net/transmission/patches: patch-qt_qtr.pro Log Message: transmission*: update to 3.00 ### All Platforms - Allow the RPC server to listen on an IPv6 address ([#161](transmission/transmission#161)) - Change `TR_CURL_SSL_VERIFY` to `TR_CURL_SSL_NO_VERIFY` and enable verification by default ([#334](transmission/transmission#334)) - Go back to using hash as base name for resume and torrent files (those stored in configuration directory) ([#122](transmission/transmission#122)) - Handle "fields" argument in "session-get" RPC request; if "fields" array is present in arguments, only return session fields specified; otherwise return all the fields as before - Limit the number of incorrect authentication attempts in embedded web server to 100 to prevent brute-force attacks ([#371](transmission/transmission#371)) - Set idle seed limit range to 1..40320 (4 weeks tops) in all clients ([#212](transmission/transmission#212)) - Add Peer ID for Xfplay, PicoTorrent, Free Download Manager, Folx, Baidu Netdisk torrent clients ([#256](transmission/transmission#256), [#285](transmission/transmission#285), [#355](transmission/transmission#355), [#363](transmission/transmission#363), [#386](transmission/transmission#386)) - Announce `INT64_MAX` as size left if the value is unknown (helps with e.g. Amazon S3 trackers) ([#250](transmission/transmission#250)) - Add `TCP_FASTOPEN` support (should result in slight speedup) ([#184](transmission/transmission#184)) - Improve ToS handling on IPv6 connections ([#128](transmission/transmission#128), [#341](transmission/transmission#341), [#360](transmission/transmission#360), [#692](transmission/transmission#692), [#737](transmission/transmission#737)) - Abort handshake if establishing DH shared secret fails (leads to crash) ([#27](transmission/transmission#27)) - Don't switch trackers while announcing (leads to crash) ([#297](transmission/transmission#297)) - Improve completion scripts execution and error handling; add support for .cmd and .bat files on Windows ([#405](transmission/transmission#405)) - Maintain a "session ID" file (in temporary directory) to better detect whether session is local or remote; return the ID as part of "session-get" response (TRAC-5348, [#861](transmission/transmission#861)) - Change torrent location even if no data move is needed ([#35](transmission/transmission#35)) - Support CIDR-notated blocklists ([#230](transmission/transmission#230), [#741](transmission/transmission#741)) - Update the resume file before running scripts ([#825](transmission/transmission#825)) - Make multiscrape limits adaptive ([#837](transmission/transmission#837)) - Add labels support to libtransmission and transmission-remote ([#822](transmission/transmission#822)) - Parse `session-id` header case-insensitively ([#765](transmission/transmission#765)) - Sanitize suspicious path components instead of rejecting them ([#62](transmission/transmission#62), [#294](transmission/transmission#294)) - Load CA certs from system store on Windows / OpenSSL ([#446](transmission/transmission#446)) - Add support for mbedtls (formely polarssl) and wolfssl (formely cyassl), LibreSSL ([#115](transmission/transmission#115), [#116](transmission/transmission#116), [#284](transmission/transmission#284), [#486](transmission/transmission#486), [#524](transmission/transmission#524), [#570](transmission/transmission#570)) - Fix building against OpenSSL 1.1.0+ ([#24](transmission/transmission#24)) - Fix quota support for uClibc-ng 1.0.18+ and DragonFly BSD ([#42](transmission/transmission#42), [#58](transmission/transmission#58), [#312](transmission/transmission#312)) - Fix a number of memory leaks (magnet loading, session shutdown, bencoded data parsing) ([#56](transmission/transmission#56)) - Bump miniupnpc version to 2.0.20170509 ([#347](transmission/transmission#347)) - CMake-related improvements (Ninja generator, libappindicator, systemd, Solaris and macOS) ([#72](transmission/transmission#72), [#96](transmission/transmission#96), [#117](transmission/transmission#117), [#118](transmission/transmission#118), [#133](transmission/transmission#133), [#191](transmission/transmission#191)) - Switch to submodules to manage (most of) third-party dependencies - Fail installation on Windows if UCRT is not installed ### Mac Client - Bump minimum macOS version to 10.10 - Dark Mode support ([#644](transmission/transmission#644), [#722](transmission/transmission#722), [#757](transmission/transmission#757), [#779](transmission/transmission#779), [#788](transmission/transmission#788)) - Remove Growl support, notification center is always used ([#387](transmission/transmission#387)) - Fix autoupdate on High Sierra and up by bumping the Sparkle version ([#121](transmission/transmission#121), [#600](transmission/transmission#600)) - Transition to ARC ([#336](transmission/transmission#336)) - Use proper UTF-8 encoding (with macOS-specific normalization) when setting download/incomplete directory and completion script paths ([#11](transmission/transmission#11)) - Fix uncaught exception when dragging multiple items between groups ([#51](transmission/transmission#51)) - Add flat variants of status icons for message log ([#134](transmission/transmission#134)) - Optimize image resources size ([#304](transmission/transmission#304), [#429](transmission/transmission#429)) - Update file icon when file name changes ([#37](transmission/transmission#37)) - Update translations ### GTK+ Client - Add queue up/down hotkeys ([#158](transmission/transmission#158)) - Modernize the .desktop file ([#162](transmission/transmission#162)) - Add AppData file ([#224](transmission/transmission#224)) - Add symbolic icon variant for the Gnome top bar and when the high contrast theme is in use ([#414](transmission/transmission#414), [#449](transmission/transmission#449)) - Update file icon when its name changes ([#37](transmission/transmission#37)) - Switch from intltool to gettext for translations ([#584](transmission/transmission#584), [#647](transmission/transmission#647)) - Update translations, add new translations for Portuguese (Portugal) ### Qt Client - Bump minimum Qt version to 5.2 - Fix dropping .torrent files into main window on Windows ([#269](transmission/transmission#269)) - Fix prepending of drive letter to various user-selected paths on Windows ([#236](transmission/transmission#236), [#307](transmission/transmission#307), [#404](transmission/transmission#404), [#437](transmission/transmission#437), [#699](transmission/transmission#699), [#723](transmission/transmission#723), [#877](transmission/transmission#877)) - Fix sorting by progress in presence of magnet transfers ([#234](transmission/transmission#234)) - Fix .torrent file trashing upon addition ([#262](transmission/transmission#262)) - Add queue up/down hotkeys ([#158](transmission/transmission#158)) - Reduce torrent properties (file tree) memory usage - Display tooltips in torrent properties (file tree) in case the names don't fit ([#411](transmission/transmission#411)) - Improve UI look on hi-dpi displays (YMMV) - Use session ID (if available) to check if session is local or not ([#861](transmission/transmission#861)) - Use default (instead of system) locale to be more flexible ([#130](transmission/transmission#130)) - Modernize the .desktop file ([#162](transmission/transmission#162)) - Update translations, add new translations for Afrikaans, Catalan, Danish, Greek, Norwegian Bokmål, Slovenian ### Daemon - Use libsystemd instead of libsystemd-daemon (TRAC-5921) - Harden transmission-daemon.service by disallowing privileges elevation ([#795](transmission/transmission#795)) - Fix exit code to be zero when dumping settings ([#487](transmission/transmission#487)) ### Web Client - Fix tracker error XSS in inspector (CVE-?) - Fix performance issues due to improper use of `setInterval()` for UI refresh (TRAC-6031) - Fix recognition of `https://` links in comments field ([#41](transmission/transmission#41), [#180](transmission/transmission#180)) - Fix torrent list style in Google Chrome 59+ ([#384](transmission/transmission#384)) - Show ETA in compact view on non-mobile devices ([#146](transmission/transmission#146)) - Show upload file button on mobile devices ([#320](transmission/transmission#320), [#431](transmission/transmission#431), [#956](transmission/transmission#956)) - Add keyboard hotkeys for web interface ([#351](transmission/transmission#351)) - Disable autocompletion in torrent URL field ([#367](transmission/transmission#367)) ### Utils - Prevent crash in transmission-show displaying torrents with invalid creation date ([#609](transmission/transmission#609)) - Handle IPv6 RPC addresses in transmission-remote ([#247](transmission/transmission#247)) - Add `--unsorted` option to transmission-show ([#767](transmission/transmission#767)) - Widen the torrent-id column in transmission-remote for cleaner formatting ([#840](transmission/transmission#840)) To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 pkgsrc/net/transmission/Makefile cvs rdiff -u -r1.9 -r1.10 pkgsrc/net/transmission/Makefile.common cvs rdiff -u -r1.3 -r1.4 pkgsrc/net/transmission/PLIST cvs rdiff -u -r1.15 -r1.16 pkgsrc/net/transmission/distinfo cvs rdiff -u -r1.45 -r1.46 pkgsrc/net/transmission-gtk/Makefile cvs rdiff -u -r1.1 -r1.2 pkgsrc/net/transmission-gtk/PLIST cvs rdiff -u -r1.52 -r1.53 pkgsrc/net/transmission-qt/Makefile cvs rdiff -u -r1.6 -r1.7 pkgsrc/net/transmission/patches/patch-qt_qtr.pro ------------------------------------------------------------------- Module Name: pkgsrc Committed By: wiz Date: Sat Jul 25 20:20:05 UTC 2020 Modified Files: pkgsrc/net/transmission-qt: Makefile Log Message: transmission-qt: needs gcc 7.x (for <optional>) Reported and tested by spz. To generate a diff of this commit: cvs rdiff -u -r1.53 -r1.54 pkgsrc/net/transmission-qt/Makefile

ckerr reviewed Feb 3, 2019

View reviewed changes

qu1ck commented Feb 4, 2019

View reviewed changes

utils/remote.c Show resolved Hide resolved

libtransmission/rpcimpl.c Show resolved Hide resolved

mikedld requested changes Feb 4, 2019

View reviewed changes

qu1ck commented Feb 4, 2019

View reviewed changes

ckerr reviewed Feb 10, 2019

View reviewed changes

qu1ck commented Feb 11, 2019

View reviewed changes

ckerr previously approved these changes Feb 11, 2019

View reviewed changes

mikedld requested changes Feb 15, 2019

View reviewed changes

qu1ck dismissed ckerr’s stale review via e3f485b February 16, 2019 03:30

qu1ck force-pushed the labels branch 3 times, most recently from 52728fa to 690351f Compare February 16, 2019 03:35

mikedld requested changes Feb 16, 2019

View reviewed changes

utils/remote.c Show resolved Hide resolved

libtransmission/rpcimpl.c Outdated Show resolved Hide resolved

mikedld reviewed Feb 16, 2019

View reviewed changes

mikedld previously approved these changes Feb 16, 2019

View reviewed changes

qu1ck dismissed mikedld’s stale review via 24c6742 February 16, 2019 07:04

qu1ck force-pushed the labels branch 2 times, most recently from 487a548 to e015c86 Compare February 16, 2019 11:31

grantrules and others added 5 commits February 16, 2019 03:53

applied changes from https://github.com/Elbandi/transmission/tree/elb…

5b26150

…andi/labels to official transmission repo

Fix compilation errors

6d3d072

Address review comments

056bb55

Changed `tr_ptrArray* labels` to `tr_ptrArray labels`; Removed tr_ptrArrayNew() tr_ptrArrayDup() tr_ptrArrayFree() Use tr_strsep() to split string by delimiters Update transmission-remote.1 Update rpc-spec.txt

Fix warning, address comments

673d932

Rebase, fix formatting and address comments

c825886

Use uncrustify to format changed files Fix "const <type>" -> "<type> const" Fix small comments

qu1ck added 2 commits February 16, 2019 03:53

Check for empty labels in daemon

25a7470

Stop on first error

31601f0

qu1ck force-pushed the labels branch from e015c86 to 31601f0 Compare February 16, 2019 11:54

mikedld approved these changes Feb 16, 2019

View reviewed changes

ckerr approved these changes Feb 16, 2019

View reviewed changes

Merge branch 'master' into labels

b516db3

ckerr merged commit 7aa12a0 into transmission:master Feb 17, 2019

mikedld added scope:remote scope:core labels Feb 17, 2019

mikedld added this to the 3.00 milestone Feb 17, 2019

qu1ck mentioned this pull request Feb 17, 2019

[Feature Request] Torrent Tagging / Categories #79

Open

qu1ck deleted the labels branch February 23, 2019 04:47

enken mentioned this pull request Mar 8, 2019

Feature Request: Filter by Drive (easy pause torrents with data on specific drives) #858

Open

Belphemur mentioned this pull request Apr 3, 2019

Add TR_TORRENT_LABELS to env variables available to scripts #868

Merged

decadent mentioned this pull request Jun 13, 2019

Please add user-defined Labels transmission-remote-gui/transgui#978

Open

j1warren mentioned this pull request Dec 11, 2019

Can't migrate from uTorrent mikedld/bt-migrate#2

Closed

ckerr added the type:feat A new feature label Oct 20, 2021

lae mentioned this pull request Dec 6, 2021

Support for labels/tagging transmission-remote-gtk/transmission-remote-gtk#133

Open

YurikaL mentioned this pull request Nov 1, 2022

Support Tags/Labels feature equeim/tremotesf2#231

Closed

LaserEyess mentioned this pull request Dec 6, 2022

Add Group support for Transmission #137

Closed

Damix48 mentioned this pull request Jun 6, 2023

Labels support for Transmission Radarr/Radarr#8661

Closed

1 task

	if (strchr(str, ',') != NULL)
	if (errmsg != NULL && strchr(str, ',') != NULL)

Add labels feature #822

Add labels feature #822

Uh oh!

Conversation

qu1ck commented Jan 26, 2019

Uh oh!

ckerr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qu1ck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikedld commented Feb 4, 2019

Uh oh!

qu1ck left a comment

Choose a reason for hiding this comment

Uh oh!

qu1ck commented Feb 4, 2019

Uh oh!

mikedld commented Feb 4, 2019

Uh oh!

qu1ck commented Feb 10, 2019

Uh oh!

ckerr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

qu1ck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ckerr commented Feb 11, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Belphemur commented Mar 30, 2019 •

edited

Loading