fix(csv): better detect need for stripping csv escaping#6262
fix(csv): better detect need for stripping csv escaping#6262nijel merged 1 commit intotranslate:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f14b6ae30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| break | ||
|
|
||
| if pounit is None: | ||
| if pounit is None and not self.has_spreadsheet_escape_prefix(csvunit.source): |
There was a problem hiding this comment.
This new guard skips the simplify() matching path for any source that starts with an apostrophe escape (for example '=A1), not just backslash-prefixed literals. That regresses prior merge behavior when exact source/location matching fails but simplified matching would still recover the intended unit (e.g., formula-like msgids that differ only by punctuation/spacing), causing those translations to be logged as "entry not found" and dropped. Limiting this skip to backslash-prefixed values avoids the false-positive case you fixed without removing existing fallback behavior for normal spreadsheet-escaped CSV produced by po2csv.
Useful? React with 👍 / 👎.
1 participant
No description provided.