fix(fomats): better handle edge cases in csv format#6261
fix(fomats): better handle edge cases in csv format#6261nijel merged 1 commit intotranslate:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89f9b7880a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Gracefully handle non-numeric values and support string escaping in round trip.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c133ce52f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| and value[0] in {"'", "\\"} | ||
| and value[1] in csvl10n.csvunit.spreadsheetescapes |
There was a problem hiding this comment.
In csv2po.remove_spreadsheet_escape, this change now strips both leading ' and \ before template matching, but CSV export only adds spreadsheet protection with a leading apostrophe (csvunit.add_spreadsheet_escape). As a result, literal values like \=A1 (in source or location) are treated as escaped formulas and normalized to =A1, which can incorrectly match and update a different PO unit instead of remaining unmatched.
Useful? React with 👍 / 👎.
1 participant
Gracefully handle non-numeric values and support string escaping in round trip.