Add support for non-BMP Unicode characters in the CLI tool #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI tool parses `strings.xml` so that they are uploaded to CDS. Even though it already supported Unicode characters, it didn't support non-BMP UTF-16 surrogate pairs (which are used by some emojis). Previously, such characters were converted to Numeric character references, in the form of &#xhhhh, which was not useful. Now, they are kept (and pushed) in the original Unicode form.
n1k0sv
approved these changes
Nov 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI tool parses
strings.xmlso that they are uploaded to CDS. Even though it already supported Unicode characters, it didn't support non-BMP UTF-16 surrogate pairs (which are used by some emojis). Previously, such characters were converted to Numeric character references, in the form of &#xhhhh, which was not useful.Now, they are kept (and pushed) in the original Unicode form.