Pass wrapped resources in AndroidMissingPolicy #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, AndroidMissingPolicy was initialized with a context, whose resources were used for getting a translated string. Using the same context for all calls can have negative side-effects. For example, if the resources configurations is changed inside an activity for forcing a locale, the context used in AndroidMissingPolicy will not be affected. This is why we no longer provide a context for constructing AndroidMissingPolicy. The original constructor has been deprecated but not removed. The provided context is ignored. The MissingPolicy interface was updated so that all methods provide a Resources object. The AndroidMissingPolicy uses the provided Resources object to retrieve translated strings. NativeCore passes the wrapped resources object to the missing policy. We don't want to pass TxResources because calling an overriden method would result in a recursive loop. All classes and unit tests have been updated. The material library has been updated to 1.7.0. Readme was updated.
n1k0sv
approved these changes
Nov 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, AndroidMissingPolicy was initialized with a context, whose resources were used for getting a translated string.
Using the same context for all calls can have negative side-effects. For example, if the resources configurations is changed inside an activity for forcing a locale, the context used in AndroidMissingPolicy will not be affected.
This is why we no longer provide a context for constructing AndroidMissingPolicy. The original constructor has been deprecated but not removed. The provided context is ignored.
The MissingPolicy interface was updated so that all methods provide a Resources object.
The AndroidMissingPolicy uses the provided Resources object to retrieve translated strings.
NativeCore passes the wrapped resources object to the missing policy. We don't want to pass TxResources because calling an overriden method would result in a recursive loop.
All classes and unit tests have been updated.
The material library has been updated to 1.7.0.
Readme was updated.