Petrakeas/target sdk 32 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tools and dependencies were updated as follows:
Gradle 7.3.3
Android Gradle Plugin 7.2.2
targetSdkVersion 32
io.github.gradle-nexus.publish-plugin 1.1.0
When generating javadoc, the attribute
"addStringOption('Xdoclint:none', 'quiet')" was causes an error and
has been replaced with "addBooleanOption('Xdoclint:none', true)"
in gradle.properties the following attribute was added to prevent
logging a warning:
"android.disableAutomaticComponentCreation=true"
We now make use of AGP's publishing block. However, the javadoc it produces
has a lower quality than the javadoc generated using our "androidJavadoc" task
in publish-helper.gradle. This is why, "withJavadocJar()" is commented out.
Currently, we only make use of withSourcesJar().
The app's manifest has been updated to specify that ".MainActivity" is exported as
required as of Android 12.
AppCompat has been updated to 1.5.0 in the SDK and the app Gradle files. BaseActivity.java and BaseAppCompatActivity,java have been moved from the app module to the SDK (txsdk) module. It's better to have these classes bundled in the library instead of instructing our users to copy paste the code from the sample app. BaseAppCompatActivity used to wrap the resources with `VectorEnabledTintResourcesWrapper` to enable TxNative functionality when "setCompatVectorFromResourcesEnabled()" was used and the app was running on older platforms (< API 21). AppCompat 1.5.0 does not need this workaround. This is why the respective code has been commented out. A comment is left for users that use an older AppCompat version and need the workaround. Readme.md has been updated regarding the previous changes. Some test methods have been added in MyApplication as commented out code.
n1k0sv
approved these changes
Sep 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.