Update CDSHandler logic to v2 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates CDSHandler logic so that it can work with the version 2 of the CDS documentation. Updates the push logic with the new job oriented approach. Adds time limit exception when pushing source strings. Updates the response data structures that the new CDS version produces (LocadeData). Refactor CLI's MainClass to account for the updates in CDSHandler and LcoaleData. Updates unit tests for the class and method refactoring. Adds unit tests for the new job oriented approach on push.
Petrakeas
force-pushed
the
petrakeas/cds-v2
branch
from
8958954 to
8cf9f1c
Compare
n1k0sv
approved these changes
Jul 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CDSHandler logic so that it can work with the version 2
of the CDS documentation. Updates the push logic with the new job
oriented approach.
Updates the response data structures that the new CDS version produces (LocadeData).
Refactor CLI's MainClass to account for the updates in CDSHandler and LcoaleData.
Updates unit tests for the class and method refactoring.
Adds unit tests for the new job oriented approach on push.