Poling translations infinite loop fix #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If downloading translations fails due to reasons such as the inability to create the downloaded file the "redirect" field in the response is empty and status is falied Based on backoff functionality, a request will be retried after 1s, 1s, 1s, 2s, 3s, 5s, 8s, 13s and then after 13s forever To avoid this we can break the loop if status of task is failed Remove retries
foteinigk
force-pushed
the
TX-14801_pull_requests_loop
branch
from
fd077f8 to
2e68793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If downloading translations fails due to reasons such as the inability to create the downloaded file the "redirect" field in the response is empty, an infinite loop can occur. To avoid this we can break the loop if task's status is failed