Add source push flags #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbairak
changed the title
foteinigk
approved these changes
Jul 7, 2023
Contributor
foteinigk
left a comment
foteinigk
left a comment
There was a problem hiding this comment.
Changes look great and work as expected!👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following two cli flags and config options:
--replace-edited-strings--keep-translationsEither the flag or the option must be set for each flag to be into effect.
Replace edited strings will not protect source strings (that share a key with a pre-existing source string) that have been edited. For example,
Suppose we upload this file using the KEYVALUEJSON format
{"1": "one"}Then we edit the source string in the Transifex editor to
one -> OneThen we try to push the following file:
{"1": "ONE"}Without the flag/option, Transifex will protect the edited version of the source string and nothing will change. If you want to discard all edits that have been done after the last push, you should use this flag/option
Keep translations will not discard translations when a source string (that shares a key with a pre-existing source string) changes. For example:
Suppose we upload this file using the KEYVALUEJSON format
{"1": "one"}Then we translate this to
one -> έναThen we try to push the following file:
{"1": "ONE"}Without the flag/option, Transifex will discard the previous translation. If you want to keep it, you should use this flag/option.
Important note: The "keep translations" functionality has not been deployed to the Transifex API yet. This PR should not be merged/released before then.