Skip to content

Fix old eval results viewing from before migration#1712

Merged
deep1401 merged 3 commits intomainfrom
fix/eval-results-old
Mar 31, 2026
Merged

Fix old eval results viewing from before migration#1712
deep1401 merged 3 commits intomainfrom
fix/eval-results-old

Conversation

@deep1401
Copy link
Copy Markdown
Member

No description provided.

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 9.09091% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/transformerlab/routers/experiment/jobs.py 9.09% 30 Missing ⚠️

📢 Thoughts on this report? Let us know!

@deep1401 deep1401 merged commit 9459da6 into main Mar 31, 2026
14 of 15 checks passed
@paragon-review
Copy link
Copy Markdown

Paragon Summary

This pull request review analyzed 5 files and found no issues. The review examined code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools.

Paragon did not detect any problems in the current diff. Proceed with merge after your normal checks.

This PR restores access to evaluation results created before a migration, so older eval runs can still be loaded and viewed correctly. It updates the API/SDK compatibility path without changing normal current behavior.

Key changes:

  • Fixed viewing of eval results created before the migration
  • Updated api/transformerlab/routers/experiment/jobs.py to handle legacy result access
  • Updated lab-sdk/src/lab/lab_facade.py for pre-migration eval compatibility
  • Synced pyproject.toml files in api/, api/localprovider, and lab-sdk/ for the compatibility changes

Confidence score: 5/5

  • This PR has low risk with no critical or high-priority issues identified
  • Score reflects clean code review with only minor suggestions or no issues found
  • Code quality checks passed - safe to proceed with merge

5 files reviewed, 0 comments


Tip: @paragon-run <instructions> to chat with our agent or push fixes!

Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants