Skip to content

Move compute provider sub-router logic under services#1697

Merged
deep1401 merged 6 commits intomainfrom
refactor/compute-provider-services
Mar 31, 2026
Merged

Move compute provider sub-router logic under services#1697
deep1401 merged 6 commits intomainfrom
refactor/compute-provider-services

Conversation

@deep1401
Copy link
Copy Markdown
Member

@deep1401 deep1401 commented Mar 30, 2026 •
edited
Loading

DO NOT MERGE BEFORE #1696

@paragon-review
Copy link
Copy Markdown

paragon-review bot commented Mar 30, 2026

Paragon Summary

This pull request review analyzed 29 files and found no issues. The review examined code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools.

Paragon did not detect any problems in the current diff. Proceed with merge after your normal checks.

This PR refactors the compute provider API by moving sub-router business logic into dedicated service modules, cleanly separating routing from implementation across setup, launch, sweep, usage, and provider-management flows. It also updates the API client and contract tests to align with the new structure, with no intended change to behavior.

Key changes:

  • Split compute provider routing into modular sub-routers under api/transformerlab/routers/compute_provider/
  • Moved core compute-provider logic into new service modules under api/transformerlab/services/compute_provider/
  • Added dedicated services for launch, sweep, usage, cluster management, provider settings, and remote job endpoints
  • Updated API client schema/endpoints in src/renderer/lib/api-client/
  • Added/updated compute provider sweep contract coverage in api/test/api/test_compute_provider_sweep_contract.py

Confidence score: 5/5

  • This PR has low risk with no critical or high-priority issues identified
  • Score reflects clean code review with only minor suggestions or no issues found
  • Code quality checks passed - safe to proceed with merge

29 files reviewed, 0 comments

Tip: @paragon-run <instructions> to chat with our agent or push fixes!

Dashboard

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 30, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 14.78495% with 1268 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...erlab/services/compute_provider/launch_template.py 10.00% 288 Missing ⚠️
...ormerlab/services/compute_provider/launch_sweep.py 10.52% 187 Missing ⚠️
...ces/compute_provider/cluster_management_service.py 11.42% 155 Missing ⚠️
...s/compute_provider/remote_job_endpoints_service.py 13.98% 123 Missing ⚠️
.../services/compute_provider/usage_report_service.py 9.47% 86 Missing ⚠️
...rvices/compute_provider/team_provider_endpoints.py 20.19% 83 Missing ⚠️
...compute_provider/user_provider_settings_service.py 14.11% 73 Missing ⚠️
...b/services/compute_provider/local_setup_service.py 21.59% 69 Missing ⚠️
...lab/services/compute_provider/sweep_job_service.py 20.28% 53 Missing and 2 partials ⚠️
...ab/services/compute_provider/launch_credentials.py 16.36% 46 Missing ⚠️
... and 12 more

📢 Thoughts on this report? Let us know!

@deep1401 deep1401 merged commit c384964 into main Mar 31, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paragon-review paragon-review[bot] paragon-review[bot] left review comments

@dadmobile dadmobile dadmobile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deep1401 @dadmobile