Skip to content

Fix common envs for multi-node runs#1689

Merged
deep1401 merged 4 commits intomainfrom
fix/common-multinode-envs
Mar 30, 2026
Merged

Fix common envs for multi-node runs#1689
deep1401 merged 4 commits intomainfrom
fix/common-multinode-envs

Conversation

@deep1401
Copy link
Copy Markdown
Member

No description provided.

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 58.62069% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
api/transformerlab/compute_providers/skypilot.py 0.00% 9 Missing ⚠️
api/transformerlab/compute_providers/slurm.py 85.00% 1 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@paragon-review
Copy link
Copy Markdown

Paragon Summary

This pull request review identified 1 issue across 1 category in 4 files. The review analyzed code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools.

This PR fixes environment handling for multi-node runs so common env variables are propagated correctly across Skypilot and Slurm jobs. It also adds/updates tests and documentation to cover the multi-node execution behavior.

Key changes:

  • Added shared environment setup for multi-node runs across providers.
  • Updated slurm.py and skypilot.py to normalize common env handling.
  • Added a new test covering Slurm multi-node environment behavior.
  • Added docs for multi-node Slurm/Skypilot task execution.

Confidence score: 3/5

  • This PR has moderate risk due to 1 high-priority issue that should be addressed
  • Score reflects significant bugs, performance issues, or architectural concerns
  • Review high-priority findings carefully before merging

4 files reviewed, 1 comment

Severity breakdown: High: 1


Tip: @paragon-run <instructions> to chat with our agent or push fixes!

Dashboard

@deep1401 deep1401 merged commit c3a3c42 into main Mar 30, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants