Fix output and files buttons on interact history#1686
Conversation
Paragon SummaryThis pull request review identified 1 issue across 1 category in 1 file. The review analyzed code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools. This PR fixes the output and files buttons in the interactive history view so they behave correctly when users review past interactions. The impact is improved usability and more reliable access to interaction outputs and associated files. Key changes:
Confidence score: 5/5
1 file reviewed, 1 comment Severity breakdown: Low: 1 Tip: |
![paragon-review[bot]](https://avatars.githubusercontent.com/in/1544258?s=60&v=4){kind=small}
| taskName={taskToDelete?.name ?? null} | ||
| onConfirm={handleConfirmDeleteTask} | ||
| /> | ||
| <ViewOutputModalStreaming |
There was a problem hiding this comment.
Bug: Stale modal state can outlive deleted history jobs
Stale modal state can outlive deleted history jobs. Users may open an orphaned modal after the row disappears. Clear modal state when the job is gone.
View Details
Location: src/renderer/components/Experiment/Interactive/Interactive.tsx (lines 1227)
Analysis
Stale modal state can outlive deleted history jobs. Users may open an orphaned modal after the row d
| What fails | The component keeps modal state even after the referenced job disappears. |
| Result | The modal can stay open even though the underlying job is no longer present in historyJobs. |
| Expected | The modal state should reset or close when the referenced history job no longer exists. |
| Impact | Users can be left viewing output or files for a deleted or missing job, causing a broken interaction and confusing UI state. |
How to reproduce
Open a history job's output or file browser, then remove that job from the history list. Observe the modal remains mounted with stale state.AI Fix Prompt
Fix this issue: Stale modal state can outlive deleted history jobs. Users may open an orphaned modal after the row disappears. Clear modal state when the job is gone.
Location: src/renderer/components/Experiment/Interactive/Interactive.tsx (lines 1227)
Problem: The component keeps modal state even after the referenced job disappears.
Current behavior: The modal can stay open even though the underlying job is no longer present in historyJobs.
Expected: The modal state should reset or close when the referenced history job no longer exists.
Steps to reproduce: Open a history job's output or file browser, then remove that job from the history list. Observe the modal remains mounted with stale state.
Provide a code fix.
Tip: Reply with @paragon-run to automatically fix this issue
2 participants
Fixes #1670