Fix Playwright hello-world-task test for UUID job IDs#1676
Merged
Conversation
The job ID regex used (\d+) which only matches numeric IDs, but job IDs are now UUIDs. Changed to (\S+) to match any non-whitespace ID format. Also made the experiment name dynamic instead of hardcoding "alpha", and clarified Docker container requirement in AGENTS.md.
deep1401
approved these changes
Mar 27, 2026
dev.py is faster for iteration, Docker is more self-contained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hello-world-task.spec.tsregex from(\d+)to(\S+)to match UUID job IDs instead of only numeric ones"alpha"Test plan