Skip to content

Fix local interactive issues#1672

Merged
deep1401 merged 2 commits intomainfrom
fix/local-stopping-interactive
Mar 27, 2026
Merged

Fix local interactive issues#1672
deep1401 merged 2 commits intomainfrom
fix/local-stopping-interactive

Conversation

@deep1401
Copy link
Copy Markdown
Member

  • Setting strict execution of setup commands with set -e -o pipefail which will cause the setup to fail if any chain command fails in the config.setup for local providers
  • Fix a job stuck for the case of no PID + Stopping state

@paragon-review
Copy link
Copy Markdown

Paragon Summary

This pull request review analyzed 2 files and found no issues. The review examined code changes, potential bugs, security vulnerabilities, performance issues, and code quality concerns using automated analysis tools.

Paragon did not detect any problems in the current diff. Proceed with merge after your normal checks.

This PR tightens local provider setup so chained commands fail fast instead of silently continuing, making local interactive setup more reliable. It also fixes an edge case where a job could get stuck when stopping without a PID.

Key changes:

  • Added strict set -e -o pipefail for local provider setup commands to fail fast on setup errors.
  • Fixed a stuck job state when a job has no PID and is in Stopping.
  • Updated local provider execution flow in api/transformerlab/compute_providers/local.py.
  • Updated remote job status handling logic in api/transformerlab/services/remote_job_status_service.py.

Confidence score: 5/5

  • This PR has low risk with no critical or high-priority issues identified
  • Score reflects clean code review with only minor suggestions or no issues found
  • Code quality checks passed - safe to proceed with merge

2 files reviewed, 0 comments


Tip: @paragon-run <instructions> to chat with our agent or push fixes!

Dashboard

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ansformerlab/services/remote_job_status_service.py 0.00% 1 Missing and 1 partial ⚠️
api/transformerlab/compute_providers/local.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@deep1401 deep1401 merged commit 5fbfc10 into main Mar 27, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants